From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 720304C6F for ; Thu, 16 Aug 2018 18:59:44 +0200 (CEST) Received: by mail-pl0-f66.google.com with SMTP id d5-v6so2384476pll.4 for ; Thu, 16 Aug 2018 09:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qdQkG1zhgVkOMQCPLuhaDMif/zqRKA5rFNu8CbX59h4=; b=ciN2MUkYh163fWYHNzZkUw3pXLGbLpmliQYgFLffnuLXtyy9M4e2qWOL33JZbc+uTZ mmA4xG5VNxioIiNM/69sk4bLVMX7WdzzuSw8/AJ4nsmsCFgTx/YxhypHOJBSQQf/PC88 7cVgJwnYuuZfk9TJHyzCuXius1nNkFqsKMEHCnNpwZWFFrsxXwSPlhNR8XF8Rp7vPg5I oBUuBVZ6Inj0z9GqVuei54PFXnx526kVszKyCc9iedyEspVY3fqiKygSYUFrv7VcKLD9 /a6/edp0Fps1mWxwHgu+iYgBU44mWQXG48unLvg2cAPOhKFZh2b2v371P75xJDir/2qT 3B+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qdQkG1zhgVkOMQCPLuhaDMif/zqRKA5rFNu8CbX59h4=; b=pCGAwqpFR9fYKw69JgmqcGMPG2MOXOYEtb/0LIFn5WrIKYlNw2EbPPptC/HOy7P4iU KI2qYgmDtWtkRE+8HImQWtRAG8j3UvwEx+7UAfz/Jksy9K7UP9ZfhJsWGLsG7DHUG5jX 80wAcqrCey0iq85+1InrkByQDCX6ubOET3+s1R0rXGVBePjdS0xx43N0C2vbcvAUX342 4AHpdCezIdZKayj9dOpx0j6Cf74CRCOrrZvhiMdqYxHAXyOZVDpI8YSynBFnNvewPT+j 0x7S34X9CIHzoxJXMTJhKajHsj/fC0Qy7203h4aIe/BAeg6ZJSjyH45SFXLtU/iohenA 8x2Q== X-Gm-Message-State: AOUpUlFHKWYZ7Bnu0MDVt4/3yJSLOQhAIRBKla4j0VBwxA0/rxgoyMQS I+KcdyLXzSLT9+/oGf0Pxxxv9A== X-Google-Smtp-Source: AA+uWPzYS75XCb119fWIr/4ZLWgkknFsn/QBYpgSdLIujYCu/5ec8gfrGUf3q3EZO/GA/FAgaONpbg== X-Received: by 2002:a17:902:8541:: with SMTP id d1-v6mr30318260plo.81.1534438783556; Thu, 16 Aug 2018 09:59:43 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m15-v6sm70236816pfj.171.2018.08.16.09.59.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Aug 2018 09:59:43 -0700 (PDT) Date: Thu, 16 Aug 2018 09:59:41 -0700 From: Stephen Hemminger To: "Wiles, Keith" Cc: "dev@dpdk.org" Message-ID: <20180816095941.5acf7dbe@xeon-e3> In-Reply-To: References: <20180816153106.7608-1-stephen@networkplumber.org> <20180816153106.7608-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 16:59:44 -0000 On Thu, 16 Aug 2018 16:34:12 +0000 "Wiles, Keith" wrote: > I looked at the Coding Guide in section 1.7.2 and it states > > 1.7.2. Definitions > - The function type should be on a line by itself preceding the function. > - The opening brace of the function body should be on a line by itself. > > static char * > function(int a1, int a2, float fl, int a4) > { Really, I thought in general DPDK followed Linux kernel style. Making little exceptions like this is a nuisance.