From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id B49CC4C6F for ; Thu, 16 Aug 2018 20:47:57 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id w24-v6so5230896wmc.1 for ; Thu, 16 Aug 2018 11:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8jA1rguQNQsWxOIHsHF/vAjDwGqJikL8hM7ycAKTsa4=; b=Pi7Z+8EC6FAzTLW2ftGuoGVQzqipTzoKDjGG2L6HMtf02Oavlak0scp/qJHaTKU04k nxuxvlBWF5vNFPNMUKrUSz0YUhFtt8BdofSMbzhfyUdf2VcxrCDyNfDIFaZRX+yyxICY oF4f+diCfiJ/8c2OhxeOAmwFkLdxodxaLT4llIe1FzLcKrCAi3IYiV3rC1/G6R1yxqnW Nb1mymVjjPLo1aaj5OJMEUZoDBufuP6dARqUXVgsLH5geE3osCYKf7fbl1K1j18GVM2G rG2rEWrQYZyN7ZXm/xpe2vAjcDpVQHF/hC/rP1mTzeDMlEpV8sW/a29e8HWVQtwyBQgR w4xw== X-Gm-Message-State: AOUpUlFQS8hUoSwJIPZ4/OkJHA4DwuyGo1VV03yEKV7ph6WnghJD2ECp rt1yC2kefLDZcQvAxznZPAWYv/DN X-Google-Smtp-Source: AA+uWPxFY/RCSTh9iIMCUNzZumvLpGrirB26epP6Ukemmhms0Q2TpDQ1MZD8ovnqfvnDE6NyNzI7zA== X-Received: by 2002:a1c:2352:: with SMTP id j79-v6mr16782232wmj.124.1534445277071; Thu, 16 Aug 2018 11:47:57 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id t4-v6sm67240wrb.45.2018.08.16.11.47.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Aug 2018 11:47:55 -0700 (PDT) From: Luca Boccassi To: dev@dpdk.org Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, tiwei.bie@intel.com, bruce.richardson@intel.com, Luca Boccassi Date: Thu, 16 Aug 2018 19:47:49 +0100 Message-Id: <20180816184750.30843-1-bluca@debian.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180814143035.19640-1-bluca@debian.org> References: <20180814143035.19640-1-bluca@debian.org> Subject: [dpdk-dev] [PATCH 1/2] bus/pci: harmonize and document rte_pci_read_config return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 18:47:57 -0000 On Linux, rte_pci_read_config on success returns the number of read bytes, but on BSD it returns 0. Document the return values, and have BSD behave as Linux does. At least one case (bnx2x PMD) treats 0 as an error, so the change makes sense also for that. Signed-off-by: Luca Boccassi --- drivers/bus/pci/bsd/pci.c | 4 +++- drivers/bus/pci/rte_bus_pci.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 655b34b7e4..175d83cf1b 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers/bus/pci/bsd/pci.c @@ -439,6 +439,8 @@ int rte_pci_read_config(const struct rte_pci_device *dev, { int fd = -1; int size; + /* Copy Linux implementation's behaviour */ + const int return_len = len; struct pci_io pi = { .pi_sel = { .pc_domain = dev->addr.domain, @@ -469,7 +471,7 @@ int rte_pci_read_config(const struct rte_pci_device *dev, } close(fd); - return 0; + return return_len; error: if (fd >= 0) diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h index 0d1955ffe0..df8f64798d 100644 --- a/drivers/bus/pci/rte_bus_pci.h +++ b/drivers/bus/pci/rte_bus_pci.h @@ -219,6 +219,8 @@ void rte_pci_unregister(struct rte_pci_driver *driver); * The length of the data buffer. * @param offset * The offset into PCI config space + * @return + * Number of bytes read on success, negative on error. */ int rte_pci_read_config(const struct rte_pci_device *device, void *buf, size_t len, off_t offset); -- 2.18.0