DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset
@ 2018-08-21 11:06 Luca Boccassi
  2018-08-21 11:17 ` Ananyev, Konstantin
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Luca Boccassi @ 2018-08-21 11:06 UTC (permalink / raw)
  To: dev; +Cc: wenzhuo.lu, konstantin.ananyev

In case of a temporary failure the ixgbe driver can return the internal
error IXGBE_ERR_RESET_FAILED to the application. Instead, return
-EAGAIN as per the public API specification.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 drivers/net/ixgbe/base/ixgbe_vf.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_vf.c b/drivers/net/ixgbe/base/ixgbe_vf.c
index 5b25a6b4d4..62f2bf2e7d 100644
--- a/drivers/net/ixgbe/base/ixgbe_vf.c
+++ b/drivers/net/ixgbe/base/ixgbe_vf.c
@@ -203,8 +203,13 @@ s32 ixgbe_reset_hw_vf(struct ixgbe_hw *hw)
 		usec_delay(5);
 	}
 
+	/*
+	 * This error code will be propagated to the app by rte_eth_dev_reset,
+	 * so use a public error code rather than the internal-only
+	 * IXGBE_ERR_RESET_FAILED
+	 */
 	if (!timeout)
-		return IXGBE_ERR_RESET_FAILED;
+		return -EAGAIN;
 
 	/* Reset VF registers to initial values */
 	ixgbe_virt_clr_reg(hw);
-- 
2.18.0

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-05 12:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-21 11:06 [dpdk-dev] [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset Luca Boccassi
2018-08-21 11:17 ` Ananyev, Konstantin
2018-09-03 12:54 ` Zhang, Qi Z
2018-09-03 14:18   ` Luca Boccassi
2018-09-03 14:18 ` [dpdk-dev] [PATCH v2] " Luca Boccassi
2018-09-05 12:35   ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).