From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id CA8972C38 for ; Thu, 23 Aug 2018 17:38:48 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id k8-v6so2772767pgq.5 for ; Thu, 23 Aug 2018 08:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z76xNbozHCA/Q8X3jpGBXGWQ2adlv147pGB/uTwXokA=; b=sECkvQQBZLmrEspepihRdJwNDKlSw/vhcKYnyWBAGvOPZZnB4l7ZZemXldQKQbQmTi ZmIk9rTWXpLexdycAb4NgydetwljOOajNBM/DNbQRkX0BOh4Jsec+PkrMB0eNLtwvfq1 iGwMcngnkQGbS916hQaWLNN8r1WNNMIGodJrGvyU0WW/AzCAfNYB+gUyPpRSxRvHvCQy O2gXo1Nqz/LXyKxTjKcfGxOV1uD1+Db9vUS7w/MMsWJdiQu9XlitfkH9w0cIPIYIcjfS pgHTvj3WbNCevSwnF2F9COa3wuH6ZrCxDYJq80XRGkeVA+7GqbHaOZ1QMFeqITk9p5V7 RmGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z76xNbozHCA/Q8X3jpGBXGWQ2adlv147pGB/uTwXokA=; b=CA9YsTctn0dkT6k/VKTOMeSsBbWuL/vsIqj/hicWkF6M5YF4l5vJ0f2V3a6mhD+K2U DWDpgFnLbagCCTuzoVU+rFb2Hud8yC7B4EmIPFo6niJS0PusTzLvGwgw8idm+BPlOTmJ MLJzFs924eVovsXrrb4vGrw741RsEH2uDm8l5NZ5dXAVHMhA/ZheeHUGDQyINRQYIvLU Bwp0dv6S92My976qK3E8nm7lutT1aXyv3SzSKRwf0x3UjNa1TJd9P8wxRsdmaqp4gZSe gK2vmFiFGI6d59pJUIm+7QXf87TzP7a6oxhv2tlRRpMEo5GAEPleotF5yMyjmLL4W/3e RwNg== X-Gm-Message-State: AOUpUlGE3W/wLkmeU6r0MsxckjHY6/5ZVMnV8SGJh4eNI1U+/g6Lvn9S ipfMnphhHcyVQ0OeFAT0OcsLpA== X-Google-Smtp-Source: AA+uWPweJMFjMgGS2Mzrwn2Tt0Z6uHCprdZKSJlEOyknlmFUogbEw9rRsPZ+vhzzk8F1d4PzFqhlaw== X-Received: by 2002:a17:902:26c:: with SMTP id 99-v6mr58348964plc.341.1535038727896; Thu, 23 Aug 2018 08:38:47 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u13-v6sm3082784pfn.59.2018.08.23.08.38.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 08:38:47 -0700 (PDT) Date: Thu, 23 Aug 2018 08:38:40 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20180823083840.4b95e78b@xeon-e3> In-Reply-To: References: <20180809175008.5787-1-stephen@networkplumber.org> <20180809175008.5787-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] netvsc: chimney buffer size error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 15:38:49 -0000 On Thu, 23 Aug 2018 15:45:17 +0100 Ferruh Yigit wrote: > On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > > Fix the error handling in setting up transmit buffer. > > If setting up chimney buffer fails, then it is not connected so > > no need to send disconnect. > > > > Allow for some unused area if full area is not used. > > > > Signed-off-by: Stephen Hemminger > > subsytem is net/netvsc, so title should be: > net/netvsc: fix chimney buffer size error handling > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: stable@dpdk.org > > Assuming you want patch to be backported. > > I will update as above while merging. There is not a high urgency to back port this. If chimney buffer setup fails the driver is unusable anyway. It is more of a theoretical error condition.