From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id 7F5BF98 for ; Fri, 24 Aug 2018 01:18:57 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id d4-v6so3593037pfn.0 for ; Thu, 23 Aug 2018 16:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZ0LUfmuleKnMvo0o/WUhgKiJpq15I5vo7W8djg2OFs=; b=Xf8jrTETRzv5UKqVSWuuOHvm3r0Hbt4mJDtx+yt2dV0A1znbbAy7lvpptqXSDhNlEQ DAIJuMlYqAlciMQjcS4N0YU/bU3mbD1ZhVv0NSN9Su6GHutYNl1A6y/mtKVVwSBwe5zW JdY4artzleGeoRwd4HkHfMw1YkY7xxMXld1NWuQtrTHUwhepXmGr1kRvg75bTyRUWQxO NgEdVW7ShhV01xon9ikKVo3uRJW0mGNKIHq+GfbBYXv5cUb4+6nT+Z28FbGXZYm5WnkP 1DOD99nR0eahu+sQVKu5cUTBuA3d1y5yWAOvO7myOk/qq22IjC1s4PwUJclspWVR5djk XRsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZ0LUfmuleKnMvo0o/WUhgKiJpq15I5vo7W8djg2OFs=; b=asv2+o5jDZUHnfedJaT63fPUaBu0K8FC0ULD2kpcuZ5y708uaXlYBnji1EUp1sfR5H 36ktXuYrQS7FjLcxc+dG5TvEADg07ygeSTJVqdqdyb2Ns42qSi00T3FrfSih71acdD+1 Avt2UnRQVjMdpkQiqKPWnk/cjP3WJhIBd6H7fX51ulMp7v2HK5mZUqVrZIKbyVVSEAvl CPw/TGMGYjkv46JeNkds7lwNB90jSOV3Qu8ODJ32ThMgLTTAZv/tvaVFgwX84VaCwjSX QSxjPpatDd5g5xYuEe8TjVCGR3mnG5k0DE2tMQvm9hbnLK9M8gVjjxF0z67yZ/M9Fde3 UObQ== X-Gm-Message-State: AOUpUlG4L8GgmJNcODUsUW2FJhHbB9GWy8cOj23sgr2cy7HOBWBYlbh2 TYENzkcEhxVuCxRVBZBh8M8uqA== X-Google-Smtp-Source: AA+uWPyx6CD0WaFqqBnCnlIGMRCPiNdd8j1T3Un5kNf2ieA6G6T26nxRJ3sugau1yKu9MG2GB0LBkA== X-Received: by 2002:a62:6c04:: with SMTP id h4-v6mr30343181pfc.113.1535066336703; Thu, 23 Aug 2018 16:18:56 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r23-v6sm7727297pfj.5.2018.08.23.16.18.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 16:18:56 -0700 (PDT) Date: Thu, 23 Aug 2018 16:18:55 -0700 From: Stephen Hemminger To: Ciara Power Cc: harry.van.haaren@intel.com, brian.archbold@intel.com, emma.kenny@intel.com, dev@dpdk.org Message-ID: <20180823161855.67747b25@xeon-e3> In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com> References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-2-git-send-email-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 23:18:57 -0000 On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > + TELEMETRY_LOG_ERR("Error - Calling thread could not be" > + " put to sleep\n"); Don't break strings across lines. It makes it harder for developers who want to use tools to look for log message in source. Checkpatch and friends allow for long line exception for string literals.