From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 647EC98 for ; Fri, 24 Aug 2018 01:22:25 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id h79-v6so2706506pfk.8 for ; Thu, 23 Aug 2018 16:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/2cvAYqqjFA4vttJxPSb6SPPChTinJK3C4/8Dnr/Nvo=; b=jCqK0tIKP1cKeuFKWF6/OE/xYSEO/xeRLyB3v1wObn4yrYlEJv7OHhtPae1xIRJxMS 7ZpYzSHsxgvWh9ueM8KYtIfBZvExsfl2ifGd7q36l77/7oXPtOqNeeam2/+Hc8FTURZW DMW5xBfLqa/EQNDDnponVc8FovVS9TN0k2P6HaW7a/wuOB1Gb4kXic0vc9qKI043IYuI pqhBWh/1bgfDv3jURd++qgocqTtdu++iX5yz4pZbcX7pIFDXk5qTOft3eQWfbC+rp03F QY9JtWS74ey5QeWC6Ce1PpsdwfrKB5xwy1+DT6O5mu4lhXcYvzdgwaVNqgJ21bx8iB5f t5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/2cvAYqqjFA4vttJxPSb6SPPChTinJK3C4/8Dnr/Nvo=; b=t081gyRIuTEeepEDimTLTa42nc/3+bMFrxoGHq7Snw3psZE5oWC6197BIUbasUqMsp KRVaXm7gkm2I2cT5jL0Rj5TOnK/f4oGSzqslpJlE9jBG65qi6+H4UEpR88P1Qt+IKVoA Uad2GfifP2Qo+kYdTUfkvAQCOK7esC0o0PvyE1AEsPHA2zQp93HFZaz4Nt+rwnnyq7BV EVFSU6BMP0DT3HGCraMrSUYEHazZeAEm4G5DISKd1R0aztEbjxrlPVkeFJCU7hPrju21 YPRDuQfr/hC8tfhio7y2zjCV4G6ebEKbNcOcCXDbuojztOLKVjM8y767q2uQ2oMOLeRi AcAA== X-Gm-Message-State: AOUpUlEbwtkW5lYjrmizeZKpevSsyqtz0aHi6XKfKAvoyT87RLRRjKz6 wozFajeX7qCOZzOOV7gtMVbt+w== X-Google-Smtp-Source: AA+uWPzZyXG2ezDjdCd0aHb2N3Ps5PWBtX5bi0MZ+/LTbyOOvQu3ZIkYAVL47gKz+5BzB+O+9aOk5A== X-Received: by 2002:a63:e40d:: with SMTP id a13-v6mr57106335pgi.289.1535066544626; Thu, 23 Aug 2018 16:22:24 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q25-v6sm7658800pfk.96.2018.08.23.16.22.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 16:22:24 -0700 (PDT) Date: Thu, 23 Aug 2018 16:22:22 -0700 From: Stephen Hemminger To: Ciara Power Cc: harry.van.haaren@intel.com, brian.archbold@intel.com, emma.kenny@intel.com, dev@dpdk.org Message-ID: <20180823162222.49445f97@xeon-e3> In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com> References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-2-git-send-email-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 23:22:25 -0000 On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > +/* Logging Macros */ > +extern int telemetry_log_level; > + > +#define TELEMETRY_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ##level, telemetry_log_level, "%s(): "fmt "\n", \ > + __func__, ##args) > + > +#define TELEMETRY_LOG_ERR(fmt, args...) \ > + TELEMETRY_LOG(ERR, fmt, ## args) > + > +#define TELEMETRY_LOG_WARN(fmt, args...) \ > + TELEMETRY_LOG(WARNING, fmt, ## args) > + > +#define TELEMETRY_LOG_INFO(fmt, args...) \ > + TELEMETRY_LOG(INFO, fmt, ## args) > + > +typedef struct telemetry_impl { > + pthread_t thread_id; > + int thread_status; > + uint32_t socket_id; > +} telemetry_impl; > + Your logging macros follow the standard DPDK style. Including automatically adding a new line. But as I look at the code, many of the TELEMETRY_LOG calls have a newline in the format. Therefore your log messages will be double spaced.