From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id CC5CF1AEEB for ; Fri, 24 Aug 2018 19:51:14 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id m84-v6so7481127lje.10 for ; Fri, 24 Aug 2018 10:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FJU3BNUHSF1ZczBx9N6vkXZuXp4wMZVLZVyZTa3bfeE=; b=BKjDOkCuahvWvtp5olMzGMGL9ue9szTR090KXxbs+Nzk2dLVUQpUyVVYA63ShlYe8D 3CKA38RUBSCUwn6diu+NqiBZodtm59y/nIoVTLy6HcJzaXbOnPQ+h4IoKj650REe4wp/ khMcj+zRVkeCQPoN3zNkgUzsJRxHTf9Kl4YQzYFu4m0ZD6F6PIU0XQyQdU3+aSqSgG9B rWR1z+lJz1KtobeiGnwiGWEqW7ULOEVJNnorrqSji9RwRlGjM17utRGXAuHOM1ekHV8V FccD5nkequQBOrmfBD8MCmNpej1uLrILlIXqTrbTtOnjhDiLY0M7Y4NjDePJQxjL9Q+j GqTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FJU3BNUHSF1ZczBx9N6vkXZuXp4wMZVLZVyZTa3bfeE=; b=Bh9iAKtUx7U9TrBGb82s4bZgpESaLWCzNJioMZV1MFcjaNM+cqgYa/3Zl72fkmsGwt Fb+afHB4NS1+ymqcPtpa4VNxjbrjeOg5roJ2pCGD2vuaIwRXP5LGrUN6aBtViOUZw7QZ r5RUXcukwkbDrVtaUCWRafYFN2qIzEjsIM9Xu2ThqrPHiak2HXyW9/R4NY6Z7MJg3Xlv f0dkMFJysEP8+ir+O+MG1OQSLuhu1ssOzd8UMokmjRfvN852DB4dkysHqcCy3GbKPBrm YuoWlzGyz0vP6iGFeu29P/MacZJiixTjRIsK4tNb0qQByhaqMLwsuQ5bA+x7TKr5ebkI Qc0w== X-Gm-Message-State: APzg51B9WQMSQ1Wyhdal6wQoAWMO/vM1rcU4Ah5GBistt717DQgtAS0q Xf2aQolywPEK/m98RCO0RqpSig== X-Google-Smtp-Source: ANB0VdY8J6Wl7z0XQ6XV1pZmdN55rEc9inqK3rbwz5FG/oXMUnFGjOuaRfvnPId8E60K8p40l2W6Vw== X-Received: by 2002:a2e:990b:: with SMTP id v11-v6mr1983632lji.87.1535133074451; Fri, 24 Aug 2018 10:51:14 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id n24-v6sm1236384ljc.7.2018.08.24.10.51.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Aug 2018 10:51:13 -0700 (PDT) Date: Fri, 24 Aug 2018 19:51:13 +0200 From: Tomasz Duszynski To: Ferruh Yigit Cc: Tomasz Duszynski , dev@dpdk.org, nsamsono@marvell.com, mw@semihalf.com, Liron Himi Message-ID: <20180824175113.GA32439@sh> References: <1535113006-9393-1-git-send-email-tdu@semihalf.com> <1535122494-30249-1-git-send-email-tdu@semihalf.com> <1535122494-30249-3-git-send-email-tdu@semihalf.com> <1d3a475c-1111-1ccc-d365-bfce148fc8f8@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1d3a475c-1111-1ccc-d365-bfce148fc8f8@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 2/6] net/mvpp2: use common code to initialize DMA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 17:51:15 -0000 On Fri, Aug 24, 2018 at 05:46:21PM +0100, Ferruh Yigit wrote: > On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > > From: Liron Himi > > > > Use common code to initialize MUSDK DMA memory buffers. > > > > Signed-off-by: Liron Himi > > Reviewed-by: Natalie Samsonov > > <...> > > > @@ -2653,24 +2651,17 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev) > > if (mrvl_dev_num) > > goto init_devices; > > > > - MRVL_LOG(INFO, "Perform MUSDK initializations"); > > - /* > > - * ret =3D=3D -EEXIST is correct, it means DMA > > - * has been already initialized (by another PMD). > > - */ > > - ret =3D mv_sys_dma_mem_init(MRVL_MUSDK_DMA_MEMSIZE); > > - if (ret < 0) { > > - if (ret !=3D -EEXIST) > > - goto out_free_kvlist; > > - else > > - MRVL_LOG(INFO, > > - "DMA memory has been already initialized by a different driver."); > > - } > > + MRVL_LOG(INFO, "Perform MUSDK initializations\n"); > > MRVL_LOG already adding "\n", no need to change original log, a few more = below. Good catch. -- - Tomasz Duszy=C5=84ski