DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion
@ 2018-08-25 19:22 Rami Rosen
  2018-08-30  4:40 ` Tiwei Bie
  2018-09-10 13:30 ` Maxime Coquelin
  0 siblings, 2 replies; 3+ messages in thread
From: Rami Rosen @ 2018-08-25 19:22 UTC (permalink / raw)
  To: dev
  Cc: stable, maxime.coquelin, tiwei.bie, zhihong.wang, yuanhan.liu,
	Rami Rosen

This patch removes an unnecessary definition of MAX_PRINT_BUFF 
in examples/vhost/main.c, since it is no longer being used.

Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 examples/vhost/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 2175c1186..5d28d03f6 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -58,9 +58,6 @@
 /* Max number of devices. Limited by vmdq. */
 #define MAX_DEVICES 64
 
-/* Size of buffers used for snprintfs. */
-#define MAX_PRINT_BUFF 6072
-
 /* Maximum long option length for option parsing. */
 #define MAX_LONG_OPT_SZ 64
 
-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion
  2018-08-25 19:22 [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion Rami Rosen
@ 2018-08-30  4:40 ` Tiwei Bie
  2018-09-10 13:30 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Tiwei Bie @ 2018-08-30  4:40 UTC (permalink / raw)
  To: Rami Rosen; +Cc: dev, stable, maxime.coquelin, zhihong.wang, yuanhan.liu


> [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion

s/defintion/definition/

Apart from that,

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks

On Sat, Aug 25, 2018 at 10:22:40PM +0300, Rami Rosen wrote:
> This patch removes an unnecessary definition of MAX_PRINT_BUFF 
> in examples/vhost/main.c, since it is no longer being used.
> 
> Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  examples/vhost/main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 2175c1186..5d28d03f6 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -58,9 +58,6 @@
>  /* Max number of devices. Limited by vmdq. */
>  #define MAX_DEVICES 64
>  
> -/* Size of buffers used for snprintfs. */
> -#define MAX_PRINT_BUFF 6072
> -
>  /* Maximum long option length for option parsing. */
>  #define MAX_LONG_OPT_SZ 64
>  
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion
  2018-08-25 19:22 [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion Rami Rosen
  2018-08-30  4:40 ` Tiwei Bie
@ 2018-09-10 13:30 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-09-10 13:30 UTC (permalink / raw)
  To: Rami Rosen, dev; +Cc: stable, tiwei.bie, zhihong.wang, yuanhan.liu



On 08/25/2018 09:22 PM, Rami Rosen wrote:
> This patch removes an unnecessary definition of MAX_PRINT_BUFF
> in examples/vhost/main.c, since it is no longer being used.
> 
> Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   examples/vhost/main.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 2175c1186..5d28d03f6 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -58,9 +58,6 @@
>   /* Max number of devices. Limited by vmdq. */
>   #define MAX_DEVICES 64
>   
> -/* Size of buffers used for snprintfs. */
> -#define MAX_PRINT_BUFF 6072
> -
>   /* Maximum long option length for option parsing. */
>   #define MAX_LONG_OPT_SZ 64
>   
> 

Applied to dpdk-next-virtio/master, with changing the title to
pass check-git-log.sh script.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-10 13:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-25 19:22 [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion Rami Rosen
2018-08-30  4:40 ` Tiwei Bie
2018-09-10 13:30 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).