From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 672FD4CA7 for ; Mon, 27 Aug 2018 16:12:36 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id z96-v6so13784452wrb.8 for ; Mon, 27 Aug 2018 07:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RkDKs1yc8Z8AaH4AYzo7rurU7taV/7iyKrDJYElDCyg=; b=HDBSh9SL7D3Ji0NVKIVeu2eUeGg1WO1gtrqm2mHl0Le5NMHzj9JSZBibVl1j7lHDY7 Uyoj8MHvaiqaVOlIGVikCf5ips7sWLLAFW0eFFLvfLXFgGl1YsRMs/iApRC6cxRpgRBw r0mAZdOPrWSwy6lOrH0jd6mamptx8B0u9ypoYrKTbWDo6i1z53FXUCJyjSIe0uXzZGnS P75GF0S9UhcGj7ot+HATRYJFcMYLg0Wd2IZZMz6Pp2/ZATBRBzE0WLJFWqyTVNMZsxVm ZRrGkwiDF068t9iCaiZrvkvjfED7bmqzoooTUi8Q2X6ukKN/Z0wch94j/w/crI1g0ya7 A/Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RkDKs1yc8Z8AaH4AYzo7rurU7taV/7iyKrDJYElDCyg=; b=o+WpSDZmHPLd726Cpnf5SVHvp9Ejnoy4Lmr7/uHCK0t4R+Q1ieAmtUzgz4x6SdQBnQ PMJ4Y0uI2awyjOy2dpdYohTWtkx53I8xQnBd+76JixGq2LMdB91mb7gq4iv3V5r6LbLp BVggPFoR8yfq0JgMt6juXW2n/5BKXh8HCo04tWkt/YyZX4QKgx+E4Q/G4PuklRd9hrc8 8FY5eLGcBXTRT925xAUSpJZQ1e7BGPSO7NpnN4zmWwitcbJ+qrYeK8RVeJXIyCJUHbmb jH2JHNF9wacFeTaBIjxrp/nFUU7DVMd4zvYBkObLngjAyXbYhtnYuUjjubJsgTRnnOsw tlGg== X-Gm-Message-State: APzg51BBeX28noQnQV6dd4FY7KKGugji/J+ZfUowozXMYv3vcOSHQJeO pffbhbYveHw5noVXOjXTnlnWsA== X-Google-Smtp-Source: ANB0VdaJWMorgJZPYJKN0k97egxWwH/QLNGCM9Nld9kMVFscY0VLHmipjv/LD/OfEUgvYssO4p2kDQ== X-Received: by 2002:a5d:5248:: with SMTP id p8-v6mr8866677wrv.198.1535379156226; Mon, 27 Aug 2018 07:12:36 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 20-v6sm16679351wmu.21.2018.08.27.07.12.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Aug 2018 07:12:35 -0700 (PDT) Date: Mon, 27 Aug 2018 16:12:19 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: dev@dpdk.org, Jerin Jacob , Gavin Hu Message-ID: <20180827141219.GE3695@6wind.com> References: <20180803132032.29038-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 14:12:36 -0000 On Fri, Aug 24, 2018 at 11:58:39AM +0100, Ferruh Yigit wrote: > On 8/3/2018 2:36 PM, Adrien Mazarguil wrote: > > This is a follow up to the "Flow API helpers enhancements" series submitted > > almost a year ago [1]. The new title is due to the reduced scope of this > > version. > > > > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a > > temporary solution pending something better [2]. It replaces a lot of > > duplicated code found in testpmd and removes some of the maintenance burden > > that developers tend to forget (me included) when modifying pattern > > item or actions (updating app/test-pmd/config.c to be clear). > > > > This series was unearthed in order to complete the implementation of > > RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to > > duplicate existing code once again. > > > > See individual patches for specific changes in this version. > > > > v2 changes: > > > > - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact. > > - Updated bonding PMD. > > - No more automatic generation of rte_flow_conv.h. > > > > [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html > > [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html > > [3] Currently the command-line parser (cmdline_flow.c) is aware of these > > actions, however config.c isn't. Flow rules with such actions cannot > > be created and cannot be validated with PMDs that implement them. > > > > Adrien Mazarguil (7): > > ethdev: add flow API object converter > > ethdev: add flow API item/action name conversion > > app/testpmd: rely on flow API conversion function > > net/failsafe: switch to flow API object conversion function > > net/bonding: switch to flow API object conversion function > > ethdev: deprecate rte_flow_copy function > > ethdev: add missing item/actions to flow object converter > > Causing build error for arm, it looks like related to rte_memcpy macro: > > .../lib/librte_ethdev/rte_flow.c: In function ‘rte_flow_conv_item_spec’: > .../lib/librte_ethdev/rte_flow.c:373:58: error: macro "rte_memcpy" passed 9 > arguments, but takes just 3 > (size > sizeof(*dst.raw) ? sizeof(*dst.raw) : size)); Thanks, noticed it after sending v2. I'll fix it for v3. -- Adrien Mazarguil 6WIND