From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id B9433F11 for ; Wed, 29 Aug 2018 18:34:44 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id u24-v6so2499703pfn.13 for ; Wed, 29 Aug 2018 09:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KTvfyAQ1r+sVw1ahN0W5qgNqmgU81ZxltadwSo7IviA=; b=CbG94vEaGUYwr2kdXh62CitL2vlFbpJcgQygjMjVcAoXC65jXkdTxYhlEOUd0sUI/h ObDqM847g7spvMYeUbl90uC3mc1hQ+YhY0QstidK4aaNwwwjoYyBr1CGxnmSpIxDV0fJ fgtqlLul069KoelPMpDK3RsiTe3halXr+1LYduPDVL3EBiyQXEQBntbe6yWeNRmjg2TC Zjz4PHo9IE31bIwrBx/XYO0q/svXz9nuhijIkX23fDnbe+fVG60uJ0ddDdlmixoHv+76 TC7NsI/BbRVz/6JL3LBpMnQ0EuvZCriN3nzFg5FEwcJiFjxKg+BgsRbNupZ6IQTEDeft SZ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KTvfyAQ1r+sVw1ahN0W5qgNqmgU81ZxltadwSo7IviA=; b=O8t1U3X77/mCLgDuJ7HHy4RSkiCowj/T8Ov24thq2QB9LIziZBy5P7XlFHg+SElHgn K25qGRMiA/uSrhe0se0SbOgkK86ydo/tE5RXsyTyjdwzeErIsG69hhPfSp3xasqYGORW 6PPIH5P3mk7UqiaM8KOga/YZvywyj6HcBzTu0p7J0CxMSmgl5c4xDjqhRQLyZyxGIJPN xMITT4A+7oDlcSkOSNRRa4/F3YVt1j2y+gU2NFr4RTzgkunrkONr/fw85gyY9Vv6l2i0 CHX7ywcqHqU2wcGIjI5u0t5aQKooWaHVdafdBii0+Yb3+CFkfrXbzCkWSOgjJcZAEbz7 fwMw== X-Gm-Message-State: APzg51DuMJRLL1CvhInE5s+nRFd7DNi+9iJTcqS4HDh4hfjejM5fD6Fr d/SMrWQC298rz35qnj4qCVPM6obyp3akGw== X-Google-Smtp-Source: ANB0VdaRon4FxZU2rpXG6rrsenFEPwIRR6hpWSwlwSl4ZHgKI48rENHXkh3cvU6/hSSKZdBd5/JaYA== X-Received: by 2002:a62:c805:: with SMTP id z5-v6mr6822372pff.44.1535560483864; Wed, 29 Aug 2018 09:34:43 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u25-v6sm6877634pfk.177.2018.08.29.09.34.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 09:34:43 -0700 (PDT) Date: Wed, 29 Aug 2018 09:34:36 -0700 From: Stephen Hemminger To: Jerin Jacob Cc: dev@dpdk.org, olivier.matz@6wind.com Message-ID: <20180829093436.3f06421f@xeon-e3> In-Reply-To: <20180829155904.GA7133@jerin> References: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com> <20180829083110.42d85024@xeon-e3> <20180829155904.GA7133@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 16:34:45 -0000 On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob wrote: > -----Original Message----- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger > > To: Jerin Jacob > > Cc: dev@dpdk.org, olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > External Email > > > > On Mon, 27 Aug 2018 18:08:35 +0530 > > Jerin Jacob wrote: > > > > > Add support for IGMP packet type. > > > > > > Signed-off-by: Jerin Jacob > > > > Could you add logic to recoginize IGMP to the software packet type identification > > rte_net_get_ptype used by drivers that don't have hardware support. > > If everyone agrees then I can do it as adding IGMP support will reduce > the performance of rte_net_get_ptype() and most of the NIC may not need it. > > Opinions? > > > > > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK? > > The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right? Then you must add it to the software matcher since most drivers are advertising L4_MASK