From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: adrien.mazarguil@6wind.com, dev <dev@dpdk.org>,
Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>,
Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: Luca Boccassi <bluca@debian.org>,
Thomas Monjalon <thomasm@mellanox.com>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: [dpdk-dev] [PATCH] ppc64: fix compilation of when AltiVec is enabled
Date: Thu, 30 Aug 2018 12:00:00 +0200 [thread overview]
Message-ID: <20180830100000.23984-1-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <CAATJJ0+p6vpYOjhch0M6e5eg0Mjh6Hun61KNGf+ScQ4veNCTdg@mail.gmail.com>
The definition of almost any newer standard like --stc=c11 will drop
__APPLCE_ALTIVEC__ which otherwise would be defined.
If that is the case then altivec.h will redefine bool to a type
conflicting with those defined by stdbool.h.
This breaks compilation of 18.08 on ppc64 like:
mlx5_nl_flow.c:407:17: error: incompatible types when assigning to type
‘__vector __bool int’ {aka ‘__vector(4) __bool int’} from type ‘int’
in_port_id_set = false;
Other alternatives were pursued on [1] but they always ended up being more
complex than what would be appropriate for the issue we face.
[1]: http://mails.dpdk.org/archives/dev/2018-August/109926.html
Change-Id: I1ed56da954e4951b9d120ca2ac0c0c218b4a0140
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
.../common/include/arch/ppc_64/rte_memcpy.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
index 75f74897b..0b3b89b56 100644
--- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
@@ -37,6 +37,17 @@
#include <string.h>
/*To include altivec.h, GCC version must >= 4.8 */
#include <altivec.h>
+/*
+ * Compilation workaround for PPC64 targets when AltiVec is fully
+ * enabled e.g. with std=c11. Otherwise there would be a type conflict
+ * of "bool" between stdbool and altivec.
+ */
+#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__)
+ #undef bool
+ /* redefine as in stdbool.h */
+ #define bool _Bool
+#endif
+
#ifdef __cplusplus
extern "C" {
--
2.17.1
next prev parent reply other threads:[~2018-08-30 10:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 14:19 [dpdk-dev] 18.08 build error on ppc64el - bool as vector type Christian Ehrhardt
2018-08-22 15:11 ` Christian Ehrhardt
2018-08-27 12:22 ` Adrien Mazarguil
2018-08-28 11:30 ` Christian Ehrhardt
2018-08-28 11:44 ` Adrien Mazarguil
2018-08-28 12:38 ` Christian Ehrhardt
2018-08-28 15:02 ` Adrien Mazarguil
2018-08-29 8:27 ` Christian Ehrhardt
2018-08-29 13:16 ` Adrien Mazarguil
2018-08-29 14:37 ` Christian Ehrhardt
2018-08-30 8:36 ` Thomas Monjalon
2018-08-30 11:22 ` Alfredo Mendoza
2018-08-31 3:44 ` Chao Zhu
2018-09-27 14:11 ` Christian Ehrhardt
2018-08-30 9:48 ` Christian Ehrhardt
2018-08-30 10:00 ` Christian Ehrhardt [this message]
2018-08-30 10:52 ` [dpdk-dev] [PATCH] ppc64: fix compilation of when AltiVec is enabled Takeshi T Yoshimura
2018-08-30 11:58 ` Christian Ehrhardt
2018-11-05 14:15 ` Thomas Monjalon
2018-11-05 21:20 ` Pradeep Satyanarayana
2018-11-07 10:03 ` Thomas Monjalon
2018-11-07 18:58 ` dwilder
2018-11-07 21:21 ` Thomas Monjalon
2018-11-07 23:53 ` Pradeep Satyanarayana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830100000.23984-1-christian.ehrhardt@canonical.com \
--to=christian.ehrhardt@canonical.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bluca@debian.org \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=thomasm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).