From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id B2BE7532C for ; Thu, 30 Aug 2018 18:37:49 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id 20-v6so8643535wrb.12 for ; Thu, 30 Aug 2018 09:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=0alJ9To+XRaASK7jfV2bm4pg+osWqVgcguYZ+Vl0AKs=; b=C42JzUXwiyPX9IqxHqMsiQMoUdKpWQBOZj7qIQmSxeRtgGUWUqxqBzXKc3viAzVmlo JGvGur4ij4CeTrVtZZ7ys48Cjlu95mOTmnNOqhzcfvVciIteqKrIClapFFt8kWf8olGg DgDOQEr0vl2INLGZNwREPnAWlC/3Q+71A/hZ7dz6MUTFXL1n8jjolziylqVw19guPfkw jd5RRQD8O+asjln8zUyVTlaDkzyA9/MItdpUIAtMi5LHE73zrzttrBRrRV5aWh+PdePc onuw5P+n6a0BKHm8sVOEHxw9p7J7RtNKvRp0cbukwBVSjyHRGYfemW1ZlKw7mN1O9exh jVMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=0alJ9To+XRaASK7jfV2bm4pg+osWqVgcguYZ+Vl0AKs=; b=J2u6a98YLYhm9HF/6+2M19zOi1YGnrYuwCxHYY8HNNteFQjxkcuCqOaFtdMwGSjbEA Q7plkM72/McskkJcdwxeerHBENXH1t2vl0QiNcTOhtFbKLME/br9PRRrwzS/f5jMf1WM UqHucDGLIF+nE+GGEQrbbelxyuBarYR3VHkMwI+S5OptWuHbzVJMT47JWfMbaSXaJgbv +tycmlzN7NjkG3M7RusF0+iDTapjQ4kh34/IB5mxMBz/jbRs0nNat/PaVKDs6V2azdGE FGySVxAyYKVfZFHhyp0YPdikmzFGnHyazxtPlkvknJmOUmC18V0upVGd0M8ZHR/sfzG3 H2cA== X-Gm-Message-State: APzg51AVfZKYagJ793P/91OMansmLmBZmG9vcQ6ugxTsan84CPz6lP3x Btu13IE0jzWgSmsv7l3ZCaVc5MsxG1g= X-Google-Smtp-Source: ANB0Vdb8I5/DLZgBWQhksyAAExkX4yymdP7pMPoGSwwdzpoqgRyi/bTg+GNYh6dT0UYNB3PRO0Xneg== X-Received: by 2002:adf:ad8e:: with SMTP id w14-v6mr8721852wrc.178.1535647069189; Thu, 30 Aug 2018 09:37:49 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 34-v6sm12209030wra.20.2018.08.30.09.37.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 09:37:48 -0700 (PDT) Date: Thu, 30 Aug 2018 18:37:32 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20180830163732.cv7hkmnuwqf3hurt@bidouze.vm.6wind.com> References: <1cd54c876b80f441c483a2f43c1c1fba219b9237.1535633784.git.gaetan.rivet@6wind.com> <20180830091518.416c3ee4@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180830091518.416c3ee4@xeon-e3> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v1 11/13] bus/pci: process declarative PCI devargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 16:37:49 -0000 On Thu, Aug 30, 2018 at 09:15:18AM -0700, Stephen Hemminger wrote: > On Thu, 30 Aug 2018 15:42:02 +0200 > Gaetan Rivet wrote: > > > +int > > +rte_pci_devargs_process(struct rte_pci_device *pdev) > > +{ > > + /* For the moment, no PCI param > > + * needs to be processed. > > + */ > > + (void) pdev; > > + return 0; > > +} > > Use __rte_unused rather than the (void) cast? Ok. I was wondering whether we should keep this patch. Its only use is to mark the proper place where this function, once it has become needed, would need to be called. PCI bus does not have any parameters configuring devices, this function will only be needed once some have been added. -- Gaëtan Rivet 6WIND