From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 528CE2BF7 for ; Fri, 31 Aug 2018 09:05:10 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id g33-v6so10197525wrd.1 for ; Fri, 31 Aug 2018 00:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to:openpgp :user-agent; bh=zTCUmI31UJ86E8Oue7W1BPPTMXQx1wPygsfl5dwEQj0=; b=XGdFnlV/nqqLkqw97o8xni3CEy7v5T5mvVgx+N47JNW/mPMTFRb6mRL1I9/zNWdZ1X wOOLFq3apWgWFIl+GQDvGNevMi5drJOR7NPh10XvKYWLYyywMcKHPQuC43xFYy1cnUXV oCb1oxpw/VYGMzpf2RrxN6g3BxOLrS3zI8O0fjkgow7nRdLkUDTgNMRdYpPFTSr9zrX+ JcvjzlZ3k1u/lqNH4euJaCmkz+rEJd0W8Sq9LkDIOR3A5lPe5Ool6C15epuX8LhiDZp/ oD0nm+wvv5wMDEIQS9q98+JEqHTSNPvC+IR2gendy04ufRuFFbZQ9ILRzrU3h3ED0xAE zjyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:openpgp:user-agent; bh=zTCUmI31UJ86E8Oue7W1BPPTMXQx1wPygsfl5dwEQj0=; b=BD5arr9PNp59E6kjaatl95liZgC7LOQeBDQGkycUKYOtKHy+yun3qV110hez/gWr0k thy3tPS11IxkvdcVTM9pi67mF6FQgmO8fGDDthjMODdF41APyJR0j66rPah6d6hwtuwv h8EXu4ZRbVwOHeO7RpMvL1P0WA9IALbPguFSyb2Iu6mHagfCxCJHlWgGmYpiZ7qVHOlZ 6j4gZRSO3e1K0RkWnXQj+TdbQJpPgz623okx7YkgO5U6GJqbc3/oJgFYTRUmZgwbyBt9 rPJbrHSxeZOdgeeulxInU1Lm0wXHR6386DVvKESby2BrejYAXRyafKnrS/7B6qyDyYvh Gc+Q== X-Gm-Message-State: APzg51AeUM/0wA+KN6gbfZYCuhA20dEABwP5MlkaY66n3j5qhCiODCdu E2IEr4wAseFqZlc9cbEnkqA+ X-Google-Smtp-Source: ANB0VdbjCUhJ0yumNB8kMpJsx4DhueqKHG7SUelVAnlhyoKiYGsGEV4DHjbKSMp9o+DYid7Y9jcU7g== X-Received: by 2002:adf:a599:: with SMTP id g25-v6mr9869394wrc.88.1535699109940; Fri, 31 Aug 2018 00:05:09 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d10-v6sm13680401wrv.70.2018.08.31.00.05.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 00:05:09 -0700 (PDT) Date: Fri, 31 Aug 2018 09:05:01 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Bruce Richardson Cc: dev@dpdk.org, Yongseok Koh , Shahaf Shuler , Matan Azrad Message-ID: <20180831070501.7m5dx4mjjazl35n7@laranjeiro-vm.dev.6wind.com> References: <85a2b398fecdf917dc22810ea0974a91ccca1d13.1535373640.git.nelio.laranjeiro@6wind.com> <20180830144617.GA14552@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180830144617.GA14552@bricha3-MOBL.ger.corp.intel.com> OpenPGP: id=A0075DA8F66A5949 preference=signencrypt User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3] net/mlx: add meson build support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 07:05:10 -0000 On Thu, Aug 30, 2018 at 03:46:17PM +0100, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 03:48:17PM +0200, Nelio Laranjeiro wrote: > > Compile Mellanox drivers when their external dependencies are met. A > > glue version of the driver can still be requested by using the > > -Denable_driver_mlx_glue=true > > > > To avoid modifying the whole sources and keep the compatibility with > > current build systems (e.g. make), the mlx{4,5}_autoconf.h is still > > generated by invoking DPDK scripts though meson's run_command() instead > > of using has_types, has_members, ... commands. > > > > Meson will try to find the required external libraries. When they are > > not installed system wide, they can be provided though CFLAGS, LDFLAGS > > and LD_LIBRARY_PATH environment variables, example (considering > > RDMA-Core is installed in /tmp/rdma-core): > > > > # CLFAGS=-I/tmp/rdma-core/build/include \ > > LDFLAGS=-L/tmp/rdma-core/build/lib \ > > LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \ > > meson output > > # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \ > > ninja -C output install > > > > Note: LD_LIBRARY_PATH before ninja is necessary when the meson > > configuration has changed (e.g. meson configure has been called), in > > such situation the LD_LIBRARY_PATH is necessary to invoke the > > autoconfiguration script. > > > > Signed-off-by: Nelio Laranjeiro > > > > Couple of minor comments inline below. Otherwise: > > Acked-by: Bruce Richardson >[...] Hi Bruce, I'll address those comments in a v4, thanks a lot for your help and review. -- Nélio Laranjeiro 6WIND