From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4F2B6231E for ; Fri, 31 Aug 2018 12:17:37 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Aug 2018 03:17:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,311,1531810800"; d="scan'208";a="69569633" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga008.jf.intel.com with SMTP; 31 Aug 2018 03:17:34 -0700 Received: by (sSMTP sendmail emulation); Fri, 31 Aug 2018 11:17:33 +0100 Date: Fri, 31 Aug 2018 11:17:33 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20180831101733.GB19592@bricha3-MOBL.ger.corp.intel.com> References: <20180831092029.4887-1-bluca@debian.org> <20180831092029.4887-2-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180831092029.4887-2-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 10:17:37 -0000 On Fri, Aug 31, 2018 at 10:20:27AM +0100, Luca Boccassi wrote: > This PMD is built with -Wno-format, which means GCC errors out if > -Wformat-security is used. > > Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code") > > Signed-off-by: Luca Boccassi > --- > drivers/raw/ifpga_rawdev/base/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/base/meson.build b/drivers/raw/ifpga_rawdev/base/meson.build > index cb6553521d..aadfc19084 100644 > --- a/drivers/raw/ifpga_rawdev/base/meson.build > +++ b/drivers/raw/ifpga_rawdev/base/meson.build > @@ -19,7 +19,7 @@ sources = [ > > error_cflags = ['-Wno-sign-compare', '-Wno-unused-value', > '-Wno-format', '-Wno-unused-but-set-variable', > - '-Wno-strict-aliasing' > + '-Wno-strict-aliasing', '-Wno-error=format-security' For readability, should format-security be placed right beside the Wno-format, since both go together? Makes the diff a little bigger, but the result would be better, I feel. /Bruce