From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 469FF4CA5 for ; Fri, 31 Aug 2018 13:33:07 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id k5-v6so10897854wre.10 for ; Fri, 31 Aug 2018 04:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to:openpgp :user-agent; bh=HP491GnYDV6IJR1b0BSjx6yB0wQWWs0rJ+hQK2RUqR0=; b=Ii7IhN3NLloqkI5mOb9w0VV6Xl5wXH2DQftxcrcqXJIMBpiFg0wva/atshDHxIUXaA 4BsUcu0OwQ9KYm9KXiOMiZvj040B+geCljzGw0XgFgSBnH+jYwtFAdf431BWwhGAEW82 R0sCqGrbU7KskbDckKz9eaN7CuL9C/P1qNfb4kZHEE+duR8lqAWSHTeCmOoLyV7Nn1KW XcwcPbx+zuXzIaITTS2CodiM+J+cTajoyrDZ1wcLMleEs10tp9W2tt8ybA+i0AFVvi6w 3mk7l84KTWjeNKuabz512ctJGqTOPXTtJX9EVA/GasnFa/5r4X+ojDS1At7hZK0l1glh Z+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:openpgp:user-agent; bh=HP491GnYDV6IJR1b0BSjx6yB0wQWWs0rJ+hQK2RUqR0=; b=rdcinE7F5SoPir8wbp6GAPX5xRO65+nDZ6C7GAtOKLJOafNHFtyy70FA9eOGGiPivz fcwmFvujsWh1QeA2nBk83ee3nxkpzeclaLRLCt4urya2k3Yf9Wpg1FTdZwAHPNOAsA1h zY8DKbAEul5tN9VDpHX0DiGWoYwxvVYXtV9mUvF4UvqXlYcDXQGy/1ubScWO7XHvXPk2 O5g7ZYRgnVKfARfC2Ww4igalId/Y5BT3dHkeZtDx7TVz8JIwTL/RmkGIn4YJpZ2S6BnL f9b07o5za9nY0Ab45lc0pZ+jaIwL+9eowkPazyk4W1L1OJQJ6Rjlq5TYVzbwwGX0/57m +vzg== X-Gm-Message-State: APzg51BM05i28M74pRTgayQBhDwj5g6prgayF9yfhiLPNtjDAgOcjPGq wwyXWtg7PwE2Vdz40KHTt9Dh X-Google-Smtp-Source: ANB0Vdb7SnxJBP7/Wt2U+hZsaWUDd8naep9JLqFQxrA49cdRDpWQjFH0Vq4FCxstXu04VJJvkTLXzQ== X-Received: by 2002:a5d:6a0e:: with SMTP id m14-v6mr10540106wru.192.1535715187072; Fri, 31 Aug 2018 04:33:07 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h206-v6sm1276323wmf.25.2018.08.31.04.33.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 04:33:06 -0700 (PDT) Date: Fri, 31 Aug 2018 13:32:59 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com> References: <20180803132032.29038-1-adrien.mazarguil@6wind.com> <20180831085337.21419-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180831085337.21419-1-adrien.mazarguil@6wind.com> OpenPGP: id=A0075DA8F66A5949 preference=signencrypt User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 11:33:07 -0000 On Fri, Aug 31, 2018 at 11:00:57AM +0200, Adrien Mazarguil wrote: > This is a follow up to the "Flow API helpers enhancements" series submitted > almost a year ago [1]. The new title is due to the reduced scope of this > version. > > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a > temporary solution pending something better [2]. It replaces a lot of > duplicated code found in testpmd and removes some of the maintenance burden > that developers tend to forget (me included) when modifying pattern > items or actions (updating app/test-pmd/config.c to be clear). > > This series was unearthed in order to complete the implementation of > RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to > duplicate existing code once again. > > See individual patches for specific changes in this version. > > v3 changes: > > - Marked rte_flow_conv() as experimental, modified net/bonding accordingly. > - Fixed compilation issue on ARM. > - Removed deprecation notice. > > v2 changes: > > - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact. > - Updated bonding PMD. > - No more automatic generation of rte_flow_conv.h. > > [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html > [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html > [3] Currently the command-line parser (cmdline_flow.c) is aware of these > actions, however config.c isn't. Flow rules with such actions cannot > be created and cannot be validated with PMDs that implement them. > > Adrien Mazarguil (7): > ethdev: add flow API object converter > ethdev: add flow API item/action name conversion > app/testpmd: rely on flow API conversion function > net/failsafe: switch to flow API object conversion function > net/bonding: switch to flow API object conversion function > ethdev: add missing items/actions to flow object converter > ethdev: deprecate rte_flow_copy function > > app/test-pmd/config.c | 407 +++------------ > app/test-pmd/testpmd.h | 7 +- > doc/guides/prog_guide/rte_flow.rst | 20 + > doc/guides/rel_notes/deprecation.rst | 7 - > drivers/net/bonding/Makefile | 1 + > drivers/net/bonding/meson.build | 1 + > drivers/net/bonding/rte_eth_bond_api.c | 6 +- > drivers/net/bonding/rte_eth_bond_flow.c | 31 +- > drivers/net/bonding/rte_eth_bond_private.h | 5 +- > drivers/net/failsafe/failsafe_ether.c | 6 +- > drivers/net/failsafe/failsafe_flow.c | 31 +- > drivers/net/failsafe/failsafe_private.h | 5 +- > lib/librte_ethdev/rte_ethdev_version.map | 1 + > lib/librte_ethdev/rte_flow.c | 666 ++++++++++++++++++------ > lib/librte_ethdev/rte_flow.h | 231 +++++++- > 15 files changed, 886 insertions(+), 539 deletions(-) > > -- > 2.11.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND