From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AD0585F27 for ; Mon, 3 Sep 2018 17:02:15 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2018 08:02:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,325,1531810800"; d="scan'208";a="70231824" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga008.jf.intel.com with SMTP; 03 Sep 2018 08:02:12 -0700 Received: by (sSMTP sendmail emulation); Mon, 03 Sep 2018 16:02:09 +0100 Date: Mon, 3 Sep 2018 16:02:09 +0100 From: Bruce Richardson To: Ilya Maximets Cc: dev@dpdk.org Message-ID: <20180903150209.GA20568@bricha3-MOBL.ger.corp.intel.com> References: <20180831133510.3121-1-bruce.richardson@intel.com> <20180903144015eucas1p2f4bee75a7eaccc76e158ae51482764c9~Q6seLK6ys2201122011eucas1p2Q@eucas1p2.samsung.com> <20180903145127eucas1p28e056d1d8be72d3cb9fec8668ccb42d4~Q62P_te0K0770907709eucas1p2T@eucas1p2.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180903145127eucas1p28e056d1d8be72d3cb9fec8668ccb42d4~Q62P_te0K0770907709eucas1p2T@eucas1p2.samsung.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 15:02:16 -0000 On Mon, Sep 03, 2018 at 05:52:58PM +0300, Ilya Maximets wrote: > On 03.09.2018 17:41, Ilya Maximets wrote: > > On 31.08.2018 16:35, Bruce Richardson wrote: > >> The driver setting of "allow_experimental_apis" was not being used when > >> building the base code. To allow this we can manually put in a check > >> in the base code files for the setting and set the appropriate cflag > >> if it's needed. > >> > >> Signed-off-by: Bruce Richardson > > > > Tested-by: Ilya Maximets > > > >> --- > >> drivers/net/e1000/base/meson.build | 3 +++ > >> drivers/net/fm10k/base/meson.build | 3 +++ > >> drivers/net/i40e/base/meson.build | 3 +++ > >> drivers/net/ixgbe/base/meson.build | 3 +++ > >> drivers/net/octeontx/base/meson.build | 6 +++++- > >> drivers/net/sfc/base/meson.build | 3 +++ > >> drivers/net/thunderx/base/meson.build | 6 +++++- > >> 7 files changed, 25 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build > >> index 5e1716def..f26f24298 100644 > >> --- a/drivers/net/e1000/base/meson.build > >> +++ b/drivers/net/e1000/base/meson.build > >> @@ -25,6 +25,9 @@ error_cflags = ['-Wno-uninitialized', '-Wno-unused-parameter', > >> '-Wno-unused-variable', '-Wno-misleading-indentation', > >> '-Wno-implicit-fallthrough'] > >> c_args = cflags > >> +if allow_experimental_apis > >> + c_args += '-DALLOW_EXPERIMENTAL_API' > >> +endif > >> foreach flag: error_cflags > >> if cc.has_argument(flag) > >> c_args += flag > >> diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build > >> index a8fc5fa8b..5525cdc82 100644 > >> --- a/drivers/net/fm10k/base/meson.build > >> +++ b/drivers/net/fm10k/base/meson.build > >> @@ -15,6 +15,9 @@ error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value', > >> '-Wno-unused-variable', '-Wno-missing-field-initializers' > >> ] > >> c_args = cflags > >> +if allow_experimental_apis > >> + c_args += '-DALLOW_EXPERIMENTAL_API' > >> +endif > >> foreach flag: error_cflags > >> if cc.has_argument(flag) > >> c_args += flag > >> diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build > >> index e6163eaa6..d4c8f872d 100644 > >> --- a/drivers/net/i40e/base/meson.build > >> +++ b/drivers/net/i40e/base/meson.build > >> @@ -16,6 +16,9 @@ error_cflags = ['-Wno-sign-compare', '-Wno-unused-value', > >> '-Wno-strict-aliasing', '-Wno-unused-but-set-variable' > > Actually, "-Wno-unused-but-set-variable" part is missing on master, so > the patch could not be applied cleanly. I tested it after removing this > flag from the patch to make it applicable. > Ok, could be. I was testing applying a few other meson patches - such as those from Luca - earlier. I think this should apply ok on top of those other sets. /Bruce