From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 866B51041 for ; Mon, 10 Sep 2018 08:19:23 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2018 23:19:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,354,1531810800"; d="scan'208";a="89089868" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.194]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2018 23:19:16 -0700 Date: Mon, 10 Sep 2018 14:18:17 +0800 From: Tiwei Bie To: "Gavin Hu (Arm Technology China)" Cc: Jens Freimann , "dev@dpdk.org" , "maxime.coquelin@redhat.com" Message-ID: <20180910061817.GA10229@debian> References: <20180906181947.20646-1-jfreimann@redhat.com> <20180906181947.20646-6-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 06:19:23 -0000 On Mon, Sep 10, 2018 at 06:02:19AM +0000, Gavin Hu (Arm Technology China) wrote: > > > > -----Original Message----- > > From: dev On Behalf Of Jens Freimann > > Sent: Friday, September 7, 2018 2:20 AM > > To: dev@dpdk.org > > Cc: tiwei.bie@intel.com; maxime.coquelin@redhat.com > > Subject: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue > > data > > > > Add support to dump packed virtqueue data to the > > VIRTQUEUE_DUMP() macro. > > > > Signed-off-by: Jens Freimann > > Acked-by: Gavin Hu > > > --- > > drivers/net/virtio/virtqueue.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > > index 53fce61b4..531ba8c65 100644 > > --- a/drivers/net/virtio/virtqueue.h > > +++ b/drivers/net/virtio/virtqueue.h > > @@ -384,6 +384,12 @@ virtqueue_notify(struct virtqueue *vq) > > uint16_t used_idx, nused; \ > > used_idx = (vq)->vq_ring.used->idx; \ The vq_ring.used doesn't exist in packed ring. > > nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ The nused can't be calculated in this way in packed ring. > > +if (vtpci_packed_queue((vq)->hw)) { \ > > + PMD_INIT_LOG(DEBUG, \ > > + "VQ: - size=%d; free=%d; last_used_idx=%d;", \ > > + (vq)->vq_nentries, (vq)->vq_free_cnt, nused); \ And nused doesn't mean last_used_idx. > > + break; \ > > +} \ > > PMD_INIT_LOG(DEBUG, \ > > "VQ: - size=%d; free=%d; used=%d; desc_head_idx=%d;" \ > > " avail.idx=%d; used_cons_idx=%d; used.idx=%d;" \ > > -- > > 2.17.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.