From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 47EC04CA0 for ; Tue, 11 Sep 2018 03:52:29 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2018 18:52:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,358,1531810800"; d="scan'208";a="261516394" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.194]) by fmsmga005.fm.intel.com with ESMTP; 10 Sep 2018 18:52:16 -0700 Date: Tue, 11 Sep 2018 09:51:17 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: Ilya Maximets , Nikolay Nikolaev , zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180911015117.GA8195@debian> References: <153202755842.21481.1772155561595981441.stgit@T460> <153202763503.21481.6074577075024787339.stgit@T460> <1828a711-9db9-4408-c9e4-be49091e8be0@redhat.com> <20180910160804eucas1p22e18ba6128dd3b5592cbca5867784749~TFaI2BMkC1648416484eucas1p2G@eucas1p2.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 01:52:29 -0000 On Mon, Sep 10, 2018 at 06:43:17PM +0200, Maxime Coquelin wrote: > Hi Ilya, > > On 09/10/2018 06:09 PM, Ilya Maximets wrote: > > Hi Maxime, > > Thanks for pointing to this patch set. I missed it somehow. > > > > This patch could not replace mine [1], because it does not improve > > the message handling from the error handling point of view. But > > it completely changes the code, so we need to negotiate the order > > in which they will be applied or combine them somehow. > > By complementary I meant both of your patches add similar things, like > vhost_user_set_vring_kick() becoming an int (even if Nikolay's version > doesn't return an error for now). > > > > > So, what's the plan? What do you think? > > On one hand Nikolay's series was posted first, and it might be easier to > just apply your patch on top. On the other hand, your patch fixes an > issue, so it will be easier to backport it if it is applied first. > > I guess we should go for your patch first to ease backporting. > > I'd like Tiwei's feedback before applying anything, as he reviewed the > first versions of both yours and Nikolay's patches. I also incline to merge the fix patch first, as it needs to be backported. > > > Few comments inline. > > > > [1] http://patchwork.dpdk.org/patch/44168/ [...]