From: Hyong Youb Kim <hyonkim@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx
Date: Tue, 11 Sep 2018 17:05:35 +0900 [thread overview]
Message-ID: <20180911080534.GA10096@HYONKIM-7R0DR.cisco.com> (raw)
In-Reply-To: <20180904101257.61129-1-ferruh.yigit@intel.com>
On Tue, Sep 04, 2018 at 11:12:56AM +0100, Ferruh Yigit wrote:
> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
> Without any specific Rx offload flag, default behavior by PMDs is to
> strip CRC.
>
> PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC
> Rx offload capability.
>
> Applications that require keeping CRC should check PMD capability first
> and if it is supported can enable this feature by setting
> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
[...]
> diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
> index 8d493ffed..abe004b24 100644
> --- a/drivers/net/enic/enic_res.c
> +++ b/drivers/net/enic/enic_res.c
> @@ -195,7 +195,6 @@ int enic_get_vnic_config(struct enic *enic)
> enic->rx_offload_capa =
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> - DEV_RX_OFFLOAD_CRC_STRIP |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
For net/enic.
Acked-by: Hyong Youb Kim <hyonkim@cisco.com>
next prev parent reply other threads:[~2018-09-11 8:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:45 [dpdk-dev] [PATCH] " Ferruh Yigit
2018-09-03 13:59 ` Andrew Rybchenko
2018-09-04 5:13 ` Shahaf Shuler
2018-09-04 5:17 ` Shahaf Shuler
2018-09-04 5:54 ` Andrew Rybchenko
2018-09-04 8:06 ` Ferruh Yigit
2018-09-04 6:29 ` Tomasz Duszynski
2018-09-04 10:12 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-09-04 10:02 ` Shahaf Shuler
2018-09-14 11:37 ` Ferruh Yigit
2018-09-19 7:34 ` David Marchand
2018-09-19 18:04 ` Ferruh Yigit
2018-09-10 7:13 ` Maxime Coquelin
2018-09-10 10:40 ` Jan Remeš
2018-09-10 11:34 ` Jerin Jacob
2018-09-18 13:05 ` Legacy, Allain
2018-09-11 8:05 ` Hyong Youb Kim [this message]
2018-09-24 17:31 ` [dpdk-dev] [PATCH] doc: announce CRC strip changes in release notes Ferruh Yigit
2018-09-24 17:01 ` Thomas Monjalon
2018-09-24 17:12 ` David Marchand
2018-09-25 15:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911080534.GA10096@HYONKIM-7R0DR.cisco.com \
--to=hyonkim@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).