DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Luca Boccassi <bluca@debian.org>, t@bricha3-MOBL.ger.corp.intel.com
Cc: dev@dpdk.org, keith.wiles@intel.com, roy.fan.zhang@intel.com,
	jingjing.wu@intel.com, wenzhuo.lu@intel.com,
	rasesh.mody@cavium.com, harish.patil@cavium.com,
	shahed.shaikh@cavium.com, amr.mokhtar@intel.com,
	shijith.thotton@cavium.com, ssrinivasan@cavium.com,
	liang.j.ma@intel.com, peter.mccarthy@intel.com,
	jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com,
	arybchenko@solarflare.com, antosh.shukla@caviumnetworks.com,
	ashish.gupta@cavium.com, yongwang@vmware.com,
	thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name
Date: Tue, 11 Sep 2018 14:06:15 +0100	[thread overview]
Message-ID: <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180910200415.8340-8-bluca@debian.org>

On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote:
> The library is called librte_pmd_lio, so rename the map file and set
> the name in the meson file so that the built library names with meson
> and legacy makefiles are the same
> 
> Fixes: bad475c03fee ("net/liquidio: add to meson build")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>

Rather than doing this renaming, can we instead add a symlink in the
install phase to map the old name to the new one? I'd like to see the
consistency of directory name, map filename and driver name enforced
strictly in the build system. Having exceptions is a pain.

/Bruce

  reply	other threads:[~2018-09-11 13:06 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 20:04 [dpdk-dev] [PATCH 00/15] rename PMDs map files to match library name and add Meson files Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 01/15] build: add Meson file for tap PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 02/15] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 03/15] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 04/15] build: add Meson files for avf PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 05/15] build: add Meson files for qede PMD Luca Boccassi
2018-09-11  9:16   ` Shaikh, Shahed
2018-09-10 20:04 ` [dpdk-dev] [PATCH 06/15] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name Luca Boccassi
2018-09-11 13:06   ` Bruce Richardson [this message]
2018-09-11 13:09     ` Luca Boccassi
2018-09-11 13:30       ` Bruce Richardson
2018-09-11 13:38         ` Luca Boccassi
2018-09-11 13:32       ` Bruce Richardson
2018-09-11 13:41         ` Luca Boccassi
2018-09-11 14:06           ` Bruce Richardson
2018-09-11 16:05             ` Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 08/15] event/opdl: rename map file to match library name Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 09/15] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 10/15] net/thunderx: rename version map after library file name Luca Boccassi
2018-09-11 13:09   ` Bruce Richardson
2018-09-10 20:04 ` [dpdk-dev] [PATCH 11/15] net/sfc: " Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 12/15] event/octeontx: " Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 13/15] compress/octeontx: " Luca Boccassi
2018-09-10 20:04 ` [dpdk-dev] [PATCH 14/15] net/vmxnet3: " Luca Boccassi
2018-09-13 21:44   ` Yong Wang
2018-09-14  7:46     ` Thomas Monjalon
2018-09-10 20:04 ` [dpdk-dev] [PATCH 15/15] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-11 16:08 ` [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD Luca Boccassi
2018-09-11 16:08   ` [dpdk-dev] [PATCH v2 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-11 16:08   ` [dpdk-dev] [PATCH v2 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-11 16:08   ` [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-13 13:24     ` Bruce Richardson
2018-09-13 13:27       ` Luca Boccassi
2018-09-13 14:48         ` Bruce Richardson
2018-09-11 16:08   ` [dpdk-dev] [PATCH v2 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-11 16:09   ` [dpdk-dev] [PATCH v2 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-11 16:09   ` [dpdk-dev] [PATCH v2 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-11 16:09   ` [dpdk-dev] [PATCH v2 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-11 16:09   ` [dpdk-dev] [PATCH v2 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-13 13:11   ` [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD Bruce Richardson
2018-09-13 13:28     ` Luca Boccassi
2018-09-13 13:41 ` [dpdk-dev] [PATCH v3 " Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-13 14:49     ` Bruce Richardson
2018-09-13 16:16       ` Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-13 13:41   ` [dpdk-dev] [PATCH v3 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-13 16:15 ` [dpdk-dev] [PATCH v4 1/9] build: add Meson file for TAP PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-13 16:16   ` [dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-18 15:00     ` Luca Boccassi
2018-09-18 15:20       ` Bruce Richardson
2018-09-18 14:58 ` [dpdk-dev] [PATCH v5 1/9] build: add Meson file for TAP PMD Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 2/9] build: add Meson file for vdev_netvsc PMD Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 3/9] build: add Meson file for crypto scheduler PMD Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 4/9] build: add Meson files for avf PMD Luca Boccassi
2018-09-18 20:48     ` Thomas Monjalon
2018-09-19  8:31       ` Bruce Richardson
2018-09-19  8:42         ` Thomas Monjalon
2018-09-19  9:45           ` Bruce Richardson
2018-09-19 10:08             ` Bruce Richardson
2018-09-19 10:15               ` Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 5/9] build: add Meson files for qede PMD Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 6/9] build: add Meson file for bbdev_null PMD Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 7/9] event/opdl: rename map file to match library name Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 8/9] build: add Meson file for opdl_event PMD Luca Boccassi
2018-09-18 14:58   ` [dpdk-dev] [PATCH v5 9/9] build: add Meson file for vmxnet3_uio PMD Luca Boccassi
2018-09-18 20:54   ` [dpdk-dev] [PATCH v5 1/9] build: add Meson file for TAP PMD Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=amr.mokhtar@intel.com \
    --cc=antosh.shukla@caviumnetworks.com \
    --cc=arybchenko@solarflare.com \
    --cc=ashish.gupta@cavium.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=harish.patil@cavium.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jingjing.wu@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=liang.j.ma@intel.com \
    --cc=maciej.czekaj@caviumnetworks.com \
    --cc=peter.mccarthy@intel.com \
    --cc=rasesh.mody@cavium.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=shahed.shaikh@cavium.com \
    --cc=shijith.thotton@cavium.com \
    --cc=ssrinivasan@cavium.com \
    --cc=t@bricha3-MOBL.ger.corp.intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).