From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 14B4A4C74 for ; Tue, 11 Sep 2018 16:06:17 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 07:06:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,360,1531810800"; d="scan'208";a="70002013" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga008.fm.intel.com with SMTP; 11 Sep 2018 07:06:15 -0700 Received: by (sSMTP sendmail emulation); Tue, 11 Sep 2018 15:06:14 +0100 Date: Tue, 11 Sep 2018 15:06:14 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20180911140614.GA22976@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-8-bluca@debian.org> <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> <1536671370.10952.18.camel@debian.org> <20180911133215.GD11744@bricha3-MOBL.ger.corp.intel.com> <1536673296.10952.22.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536673296.10952.22.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 14:06:18 -0000 On Tue, Sep 11, 2018 at 02:41:36PM +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote: > > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > > > The library is called librte_pmd_lio, so rename the map file > > > > > and > > > > > set > > > > > the name in the meson file so that the built library names with > > > > > meson > > > > > and legacy makefiles are the same > > > > > > > > > > Fixes: bad475c03fee ("net/liquidio: add to meson build") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Luca Boccassi > > > > > > > > Rather than doing this renaming, can we instead add a symlink in > > > > the > > > > install phase to map the old name to the new one? I'd like to see > > > > the > > > > consistency of directory name, map filename and driver name > > > > enforced > > > > strictly in the build system. Having exceptions is a pain. > > > > > > > > /Bruce > > > > > > We could, but the pain gets shifted on packagers then - what about > > > renaming the directory entirely to net/lio? > > > > For packagers, what sort of ABI compatibility guarantees do you try > > and > > keep between releases. Is this something that just needs a one- > > release ABI > > announcement, as with other ABI changes? > > > > /Bruce > > Currently in Debian/Ubuntu we are using the ABI override (because of > the sticky ABI breakage issue) so the filenames and package names are > different on every release anyway. > > So in theory we could change the name of the libs and packages, but > what I'm mostly worried about is keeping consistency and some level of > compatibility between old and new build systems, isn't that an issue? > It's a good question, and I suspect everyone will have their own opinion. Personally, I take the view that moving build system involves quite a number of changes anyway, so we should take the opportunity to clean up a few other things at the same time. This is why I'm so keep on trying to keep everything consistent as far as possible throughout the system and not put in special cases. For many of these a) if we put in lots of name overrides now we'll probably never get rid of them, and b) it's more likely that future drivers will adopt the same technique to have different naming of drivers and directories. However, if keeping sonames consistent is a major concern, then perhaps we should look to rename some directories, like you suggested before. /Bruce