From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 71B4B1559 for ; Wed, 12 Sep 2018 11:30:37 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2018 02:30:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,364,1531810800"; d="scan'208";a="261910458" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga005.fm.intel.com with SMTP; 12 Sep 2018 02:30:23 -0700 Received: by (sSMTP sendmail emulation); Wed, 12 Sep 2018 10:30:22 +0100 Date: Wed, 12 Sep 2018 10:30:22 +0100 From: Bruce Richardson To: Shahaf Shuler Cc: Marcelo Ricardo Leitner , Luca Boccassi , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20180912093021.GA15632@bricha3-MOBL.ger.corp.intel.com> References: <20180907141342.GA21576@bricha3-MOBL.ger.corp.intel.com> <20180907152418.GA14360@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] Change in binary name w/ meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 09:30:37 -0000 On Wed, Sep 12, 2018 at 06:21:06AM +0000, Shahaf Shuler wrote: > Friday, September 7, 2018 6:24 PM, Bruce Richardson: > > Subject: Re: [dpdk-dev] Change in binary name w/ meson build > > > > On Fri, Sep 07, 2018 at 03:13:43PM +0100, Bruce Richardson wrote: > > > On Wed, Sep 05, 2018 at 11:52:10AM +0000, Shahaf Shuler wrote: > > > > Hi Bruce, > > > > > > > > > > > > Playing w/ meson build I got to know that the binary name for testpmd > > > > got changed to dpdk-testpmd. > > > > > > > > > > > > Not sure if it was discussed or not before, but such change will affect > > > > all the automation used to run testpmd w/ the old build system. > > > > > > > > > > > > What is the reason for the change in the name? > > > > > > The primary driver was that the autotest binary could not be called "test" > > > any more, since that is a reserved name. When appending a dpdk prefix > > > to the test binary, I felt for consistency that other binaries should > > > have a dpdk prefix too, to indicate that they come from DPDK. If this > > > is a problem, we can remove the prefix from the binaries easily enough. > > > > > Also to point out that when building with meson the scripting is going to have > > to change anyway, right. The actual build commands are different, the > > configuration commands are different, and the directories the resulting > > binaries are placed in are different too. Therefore, I'd like to keep the name > > prefixes if possible, since for automated tooling on DPDK there are going to > > have to be lots of other changes anyway. > > > > For packagers, the rename I understand could be problematic, but that could > > probably be solved by symlinks in the install phase. > > I am fine w/ the testpmd -> dpdk-testpmd change as it is more correct to put it explicitly under the dpdk namespace. > I was raising this point because I am not sure it was explicitly mentioned on the release notes and was hoping to get feedback also from the people who build dpdk for distro > Agreed, I should have got wider feedback for this change at the time, but it's not to late to fix if it is problematic, I think. I too like having the namespacing, though. /Bruce