From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 50A225681 for ; Thu, 13 Sep 2018 12:51:46 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 03:51:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,368,1531810800"; d="scan'208";a="85635982" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga002.fm.intel.com with SMTP; 13 Sep 2018 03:51:43 -0700 Received: by (sSMTP sendmail emulation); Thu, 13 Sep 2018 11:51:42 +0100 Date: Thu, 13 Sep 2018 11:51:41 +0100 From: Bruce Richardson To: Shahaf Shuler Cc: =?iso-8859-1?Q?N=E9lio?= Laranjeiro , Yongseok Koh , Matan Azrad , "bluca@debian.org" , "dev@dpdk.org" Message-ID: <20180913105141.GA22324@bricha3-MOBL.ger.corp.intel.com> References: <9c646fc088242e679a3e4fda541f58674b064b1e.1535699721.git.nelio.laranjeiro@6wind.com> <20180905114746.117936-1-shahafs@mellanox.com> <20180907103429.GA12540@bricha3-MOBL.ger.corp.intel.com> <20180913092206.GA17576@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 10:51:47 -0000 On Thu, Sep 13, 2018 at 10:12:18AM +0000, Shahaf Shuler wrote: > Hi Bruce, > > Sorry for the late reply. Holiday time in Israel. > No problem! Hope you had a good break. :-) > Thursday, September 13, 2018 12:22 PM, Bruce Richardson: > > Subject: Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support > > > > On Fri, Sep 07, 2018 at 11:34:29AM +0100, Bruce Richardson wrote: > > > On Wed, Sep 05, 2018 at 02:47:46PM +0300, Shahaf Shuler wrote: > > > > From: Nelio Laranjeiro > > > > > * Very minor suggestion: is it neater to use "args: '-include ' + arg[1]", > > > instead of using prefix with the #include syntax? [Assuming the former > > > works] > > I don't understand the benefit with this change. Is there? > No, it was just a suggestion as to what looked neater in the code. Use whatever you prefer. > > > > > > > Any plans for a new version of this? If so, can I also suggest splitting the patch > > into two, one for mlx4 and the other for mlx5. > > No problem to split. > > Another change in plans: > diff --git a/meson_options.txt b/meson_options.txt > index 484f3e2601..444a380d97 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -1,7 +1,7 @@ > option('allow_invalid_socket_id', type: 'boolean', value: false, > description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly') > option('enable_driver_mlx_glue', type: 'boolean', value: false, > - description: 'Enable glue library for Mellanox ConnectX-3/4/5 NIC PMD') > + description: 'Enable glue library for Mellanox PMDs') > option('enable_kmods', type: 'boolean', value: true, > description: 'build kernel modules') > option('examples', type: 'string', value: '', > > I don't see the need to constantly update with each device being added. > Good idea! /Bruce