From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7CF155F72 for ; Thu, 13 Sep 2018 14:41:47 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 05:41:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,369,1531810800"; d="scan'208";a="72666594" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga007.jf.intel.com with SMTP; 13 Sep 2018 05:41:43 -0700 Received: by (sSMTP sendmail emulation); Thu, 13 Sep 2018 13:41:42 +0100 Date: Thu, 13 Sep 2018 13:41:42 +0100 From: Bruce Richardson To: Shahaf Shuler Cc: yskoh@mellanox.com, matan@mellanox.com, nelio.laranjeiro@6wind.com, bluca@debian.org, dev@dpdk.org Message-ID: <20180913124142.GA1776@bricha3-MOBL.ger.corp.intel.com> References: <20180905114746.117936-1-shahafs@mellanox.com> <3c634e089dbcc5a6a7fc7cbff91958598f595e57.1536839688.git.shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c634e089dbcc5a6a7fc7cbff91958598f595e57.1536839688.git.shahafs@mellanox.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 12:41:47 -0000 On Thu, Sep 13, 2018 at 03:11:05PM +0300, Shahaf Shuler wrote: > From: Nelio Laranjeiro > > Compile Mellanox driver when its external dependencies are met. A > glue version of the driver can still be requested by using the > -Denable_driver_mlx_glue=true > > To avoid modifying the whole sources and keep the compatibility with > current build systems (e.g. make), the mlx5_autoconf.h is still > generated by invoking DPDK scripts though meson's run_command() instead > of using has_types, has_members, ... commands. > This part of the commit message is no longer accurate. > Meson will try to find the required external libraries. When they are > not installed system wide, they can be provided though CFLAGS, LDFLAGS > and LD_LIBRARY_PATH environment variables, example (considering > RDMA-Core is installed in /tmp/rdma-core): > > # CLFAGS=-I/tmp/rdma-core/build/include \ > LDFLAGS=-L/tmp/rdma-core/build/lib \ > LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \ > meson output > # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \ > ninja -C output install > > Note: LD_LIBRARY_PATH before ninja is necessary when the meson > configuration has changed (e.g. meson configure has been called), in > such situation the LD_LIBRARY_PATH is necessary to invoke the > autoconfiguration script. > > Signed-off-by: Nelio Laranjeiro > Acked-by: Bruce Richardson > Signed-off-by: Shahaf Shuler The signoffs should be together, followed by the ack. Otherwise LGTM (for both patches) /Bruce