From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 8DD8B58FA for ; Fri, 14 Sep 2018 17:08:20 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180914150819euoutp022e647194e247bffd931f40f96229615b~UTLHV2sCs1603916039euoutp02F for ; Fri, 14 Sep 2018 15:08:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180914150819euoutp022e647194e247bffd931f40f96229615b~UTLHV2sCs1603916039euoutp02F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1536937699; bh=ow0JUjlAY8XgCK4QUN3zUUMbOmgyU8t2HC65ZXucbeE=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=apH+H9HZtmueg5D6Dp6b1gOUtorUkbNEdFTap0zItgfwpTYAtF/1gK5OtuTmuFypG BNMf5YGtJXLCZBA+7LZISGNkwuFWTu4O9T8NKdocF1yqpzhZkrgrdF99M/2CE3BTkY 7kV/x307sgBRl10Z3ZBrxSO8UiCmEOBWA9AHi2as= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180914150819eucas1p27bfbca5a81d32e9c32697d2d497ca164~UTLG7u8eQ0598205982eucas1p28; Fri, 14 Sep 2018 15:08:19 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 72.DB.04294.2EECB9B5; Fri, 14 Sep 2018 16:08:18 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k; Fri, 14 Sep 2018 15:08:18 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180914150817eusmtrp1f4939539ae3ebc99a89195622d2893e0~UTLF2lYO92269822698eusmtrp1l; Fri, 14 Sep 2018 15:08:17 +0000 (GMT) X-AuditID: cbfec7f4-835ff700000010c6-32-5b9bcee226be Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B1.09.04128.1EECB9B5; Fri, 14 Sep 2018 16:08:17 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20180914150817eusmtip2434c2fbd139975a9e71516edfed5e4b8~UTLFb7-wb0785507855eusmtip2t; Fri, 14 Sep 2018 15:08:17 +0000 (GMT) To: Thomas Monjalon , Arnon Warshavsky Cc: dev@dpdk.org, Stephen Hemminger , Andrzej Ostruszka From: Ilya Maximets Date: Fri, 14 Sep 2018 18:10:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6831653.AvvoQPlBBt@xps> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7djPc7qPzs2ONvjQo2ux89tJdosrr9cx W7z7tJ3J4kr7T3aLxXfkLD49OMHiwObxa8FSVo9jN6exe/ScnMfkseDmXyaPvi2rGD1ebikI YIvisklJzcksSy3St0vgynj66iRzwUfOio1fzrM0MD5l72Lk5JAQMJF4tW0imC0ksIJR4uTD 8i5GLiD7C6PEpEvN7BDOZ0aJV3u3wXVM2bWMCSKxnFHi4/x+qKqPjBK3W5sZQaqEBcIlpi97 xQZiiwj4SxzYc5gVxGYWyJC4OL2NGcRmE9CROLX6CFg9i4CqxMTvq8DiogIREkceLASL8woI Spyc+YSli5GDgxOoZuEUAYgx4hJNX1ZCjZSX2P52DjPIDRICm9glrv+7xgzRWybxdsskJoir XSQ23WthhrCFJV4d3wL1jYzE6ck9LBB2vcT9lpeMEIM6GCWmH/oH1WwvseX1OXaQI5gFNCXW 79KHCDtKdE86yAgSlhDgk7jxVhDiHj6JSdumM0OEeSU62oQgqlUkfh9cDnWBlMTNd5/ZJzAq zULy5Cwkn81C8tkshL0LGFlWMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525iBKaf0/+Of9nB uOtP0iFGAQ5GJR5ejc2zo4VYE8uKK3MPMUpwMCuJ8K4PnRUtxJuSWFmVWpQfX1Sak1p8iFGa g0VJnJdPKy1aSCA9sSQ1OzW1ILUIJsvEwSnVwOghJaix48nN/ca3tnHwNWbvX/XqX/ScFRHp mqVV6uaCYqe3iMj8iZG4tX5K0Sz3VhHuL+e3Xf6uc+Vmq7fwZlNFk/3sUTtMVqe8MH0qdv+H iZer0fT0BO8qm+wVy9Y/krTfsMCjqEdfPvC9kcZHy6Qjky1F5u1+fmyuyZbvURtOd5zoOtx/ Y6MSS3FGoqEWc1FxIgAF2fkTOwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsVy+t/xe7oPz82ONpj63sRi57eT7BZXXq9j tnj3aTuTxZX2n+wWi+/IWXx6cILFgc3j14KlrB7Hbk5j9+g5OY/JY8HNv0wefVtWMXq83FIQ wBalZ1OUX1qSqpCRX1xiqxRtaGGkZ2hpoWdkYqlnaGwea2VkqqRvZ5OSmpNZllqkb5egl/H0 1Unmgo+cFRu/nGdpYHzK3sXIySEhYCIxZdcypi5GLg4hgaWMEhPOHmWGSEhJ/Ph1gRXCFpb4 c62LDcQWEnjPKPHkhhGILSwQLjF92SuwuIiAr8SZS2+BhnJwMAtkSPzdLwIx8yOjxK6Nv8Hm sAnoSJxafYQRxOYVsJO48usIWJxFQFVi4vdVYHtFBSIkVi9/wQpRIyhxcuYTFpCZnEA1C6cI gISZBdQl/sy7xAxhi0s0fVnJCmHLS2x/O4d5AqPQLCTds5C0zELSMgtJywJGllWMIqmlxbnp ucVGesWJucWleel6yfm5mxiB8bbt2M8tOxi73gUfYhTgYFTi4dXYPDtaiDWxrLgy9xCjBAez kgjv+tBZ0UK8KYmVValF+fFFpTmpxYcYTYF+m8gsJZqcD0wFeSXxhqaG5haWhubG5sZmFkri vOcNKqOEBNITS1KzU1MLUotg+pg4OKUaGJcyZi3or/jFJX3+RttZw0LGUuZCj6Mp5RaOX9WM YvW2aHcFdmga/jN/cKVkY2/6x5WHy+f2FbrlbOu/q2iTrHDB7FzyXIGsiFXbTTPvTM7aWxCm l+bb+PRBqTyT1qJ1Fo+t3P7YfvzpI6L+Ymut7ZI+a4sVVtXTN5U79ayedk3+AqtG9URPJZbi jERDLeai4kQAUMeScc0CAAA= Message-Id: <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com> X-CMS-MailID: 20180914150818eucas1p299538375ea77dfc477516918818c3ab8 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33 References: <20180815153346.11495-1-i.maximets@samsung.com> <6831653.AvvoQPlBBt@xps> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 15:08:20 -0000 Hi Thomas. Beside your questions, There is another patch that targeted to fix this issue: http://patches.dpdk.org/patch/44020/ And one similar to mine that I missed while sending: http://patches.dpdk.org/patch/43692/ So, I'm not sure which one should be accepted and if I need to update my version. What do you think? Stephen? Andrzej? Best regards, Ilya Maximets. On 14.09.2018 17:50, Thomas Monjalon wrote: > 16/08/2018 07:25, Arnon Warshavsky: >> Hi Ilya >> >> Let's use single quotes instead of variable. >> >> >> Using the script directly with single quotes loses the ability to reuse it >> with an additional set of folders , expressions and RET_ON_FAIL. > > I don't know awk. Please could you explain what we are loosing and why? > >> If we wish to keep the awk code in this file and not in a separate file, >> maybe receiving the awk script parameters from the function >> check_forbidden_additions( ) can also preserve the ability to reuse in >> future cases. > > Yes I feel we could add some parameters to this function. > And yes, we could move the awk script in a separate file. > Actually, it would be better to keep checkpatches.sh as a wrapper script > calling various tools. > > Thanks > > > >