From: Xiaoyun Li <xiaoyun.li@intel.com>
To: qi.z.zhang@intel.com, wenzhuo.lu@intel.com, ferruh.yigit@intel.com
Cc: dev@dpdk.org, Xiaoyun Li <xiaoyun.li@intel.com>
Subject: [dpdk-dev] [PATCH v2 4/7] net/ixgbe/base: relpace an operation in X550 setup
Date: Mon, 17 Sep 2018 17:28:11 +0800 [thread overview]
Message-ID: <20180917092814.59921-5-xiaoyun.li@intel.com> (raw)
In-Reply-To: <20180917092814.59921-1-xiaoyun.li@intel.com>
Replace "=" operation with "|=" operation to only set the intended
register bits.
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
drivers/net/ixgbe/base/ixgbe_x550.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
index c9f1563a9..d5bbfadd4 100644
--- a/drivers/net/ixgbe/base/ixgbe_x550.c
+++ b/drivers/net/ixgbe/base/ixgbe_x550.c
@@ -2780,9 +2780,9 @@ s32 ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw,
(IXGBE_CS4227_EDC_MODE_SR << 1));
if (setup_linear)
- reg_phy_ext = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
+ reg_phy_ext |= (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
else
- reg_phy_ext = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
+ reg_phy_ext |= (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
ret_val = hw->phy.ops.write_reg(hw, reg_slice,
IXGBE_MDIO_ZERO_DEV_TYPE, reg_phy_ext);
--
2.17.1
next prev parent reply other threads:[~2018-09-17 9:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 16:37 [dpdk-dev] [PATCH 0/8] update ixgbe base code Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 1/8] net/ixgbe/base: update the license Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 2/8] net/ixgbe/base: cleanup codes Xiaoyun Li
2018-09-13 9:02 ` Ferruh Yigit
2018-09-17 6:46 ` Li, Xiaoyun
2018-09-10 16:37 ` [dpdk-dev] [PATCH 3/8] net/ixgbe/base: add FW recovery mode check Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 4/8] net/ixgbe/base: relpace an operation in X550 setup Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 5/8] net/ixgbe/base: update X550 SFP identification Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 6/8] net/ixgbe/base: add support for DCB registers dump Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 7/8] net/ixgbe: remove Light Spring code Xiaoyun Li
2018-09-10 16:37 ` [dpdk-dev] [PATCH 8/8] net/ixgbe/base: update README file Xiaoyun Li
2018-09-13 2:16 ` [dpdk-dev] [PATCH 0/8] update ixgbe base code Zhang, Qi Z
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 0/7] " Xiaoyun Li
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 1/7] net/ixgbe/base: update the license Xiaoyun Li
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 2/7] net/ixgbe/base: cleanup codes Xiaoyun Li
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 3/7] net/ixgbe/base: add FW recovery mode check Xiaoyun Li
2018-09-17 9:28 ` Xiaoyun Li [this message]
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 5/7] net/ixgbe/base: update X550 SFP identification Xiaoyun Li
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 6/7] net/ixgbe/base: add support for DCB registers dump Xiaoyun Li
2018-09-17 9:28 ` [dpdk-dev] [PATCH v2 7/7] net/ixgbe/base: update README file Xiaoyun Li
2018-09-19 14:31 ` [dpdk-dev] [PATCH v2 0/7] update ixgbe base code Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917092814.59921-5-xiaoyun.li@intel.com \
--to=xiaoyun.li@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).