From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AA67F5B1E for ; Mon, 17 Sep 2018 17:17:32 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 08:17:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,385,1531810800"; d="scan'208";a="257960203" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.106]) by orsmga005.jf.intel.com with SMTP; 17 Sep 2018 08:17:22 -0700 Received: by (sSMTP sendmail emulation); Mon, 17 Sep 2018 16:17:17 +0100 Date: Mon, 17 Sep 2018 16:17:16 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20180917151716.GA16172@bricha3-MOBL.ger.corp.intel.com> References: <20180829160252.7890-1-bruce.richardson@intel.com> <4200777.W2uOughg41@xps> <20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com> <2047675.hNTm73f6kF@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2047675.hNTm73f6kF@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 15:17:33 -0000 On Mon, Sep 17, 2018 at 03:38:58PM +0200, Thomas Monjalon wrote: > 17/09/2018 14:54, Bruce Richardson: > > On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote: > > > 29/08/2018 18:02, Bruce Richardson: > > > > Add in a cross-file to enable 32-bit compile tests as part > > > > of the test-meson-builds script. > > > > > > > > Signed-off-by: Bruce Richardson > > > > --- > > > > NOTE: For ease of use, it's recommended that meson 0.47 be used for > > > > this testing. With earlier versions, it may be necessary to ensure that > > > > the same development packages are installed for both 64-bit and 32-bit. > > > > --- > > > > config/x86/i686_sse4_linuxapp_gcc | 18 ++++++++++++++++++ > > > > devtools/test-meson-builds.sh | 4 ++++ > > > > 2 files changed, 22 insertions(+) > > > > > > I'm not sure about adding this test as mandatory, because 32-bit version > > > of libraries can be hard to get, especially libbsd and libnuma. > > > I hope this test will be run by all developers, so we should not discourage > > > them by adding too many requirements. > > > Opinion? Idea? > > > > Libbsd is not required, but yes, libnuma is, so you do need a 32-bit > > libnuma (devel) installed to run this test. I would expect that to be > > available on most distros though. I'm open to suggestions as to how to make > > this optional, but I do think that sanity checking 32-bit is good practice > > to avoid errors, e.g. those wonderful printf format strings for uint64_t.* > > I agree and I am testing i686 with the "make build system". > I define DPDK_DEP_NUMA=n which disables any NUMA option. > Can we have this kind of tweak with meson? > > Or perhaps we can just have an option in the script to disable this test? > Actually, do you see build failures with 32-bit without the numa or BSD libraries? I removed 32-bit versions of both dev packages and everything still compiles? The setting of the appropriate defines is based on detected libraries. /Bruce