Re: [dpdk-dev] [PATCH] net/avf: remove unused variables and label

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Sep 17, 2018 at 03:53:40PM +0100, Ferruh Yigit wrote:
> On 9/13/2018 3:44 PM, Bruce Richardson wrote:
> > Compiling with all warnings turned on causes errors about unused variables
> > and an unused label. Remove these to allow building without having to
> > disable those warnings.
> 
> If this is fixing some build errors should it be backported?
> 
> And why we didn't get those warnings until now, aren't we already compiling with
> all warnings turned on?
> 
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
It does not appear so. When we add support for building this driver with
meson, the compiler warnings then appeared [See
http://patches.dpdk.org/patch/44698/]. 

While you can backport I'm not sure it's worthwhile, unless you plan on
backporting the new meson support too.  The warnings don't come from
external header files that apps would be using directly with unknown
compiler flags, but are internal to DPDK and don't seem to cause any issues
with "make" builds.

Regards,
/Bruce