From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 03D75568A for ; Mon, 17 Sep 2018 17:21:03 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 08:21:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,385,1531810800"; d="scan'208";a="257960958" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.106]) by orsmga005.jf.intel.com with SMTP; 17 Sep 2018 08:21:00 -0700 Received: by (sSMTP sendmail emulation); Mon, 17 Sep 2018 16:21:00 +0100 Date: Mon, 17 Sep 2018 16:20:59 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Jingjing Wu , Wenzhuo Lu , dev@dpdk.org Message-ID: <20180917152059.GB16172@bricha3-MOBL.ger.corp.intel.com> References: <20180913144405.72772-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] net/avf: remove unused variables and label X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 15:21:04 -0000 On Mon, Sep 17, 2018 at 03:53:40PM +0100, Ferruh Yigit wrote: > On 9/13/2018 3:44 PM, Bruce Richardson wrote: > > Compiling with all warnings turned on causes errors about unused variables > > and an unused label. Remove these to allow building without having to > > disable those warnings. > > If this is fixing some build errors should it be backported? > > And why we didn't get those warnings until now, aren't we already compiling with > all warnings turned on? > > > > > Signed-off-by: Bruce Richardson > It does not appear so. When we add support for building this driver with meson, the compiler warnings then appeared [See http://patches.dpdk.org/patch/44698/]. While you can backport I'm not sure it's worthwhile, unless you plan on backporting the new meson support too. The warnings don't come from external header files that apps would be using directly with unknown compiler flags, but are internal to DPDK and don't seem to cause any issues with "make" builds. Regards, /Bruce