From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3CB205F25 for ; Mon, 17 Sep 2018 17:44:27 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 08:44:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,386,1531810800"; d="scan'208";a="73919829" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.106]) by orsmga008.jf.intel.com with SMTP; 17 Sep 2018 08:44:22 -0700 Received: by (sSMTP sendmail emulation); Mon, 17 Sep 2018 16:44:22 +0100 Date: Mon, 17 Sep 2018 16:44:21 +0100 From: Bruce Richardson To: Alex Kiselev Cc: "dev@dpdk.org" , Stephen Hemminger Message-ID: <20180917154421.GB4520@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v6 2/2] librte_lpm: Improve performance of the delete and add functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 15:44:27 -0000 On Tue, Jul 17, 2018 at 12:20:19PM +0300, Alex Kiselev wrote: > librte_lpm: Improve lpm6 performance > > There is no need to rebuild the whole LPM tree > when a rule is deleted. This patch addresses this > issue introducing new delete operation. > > Signed-off-by: Alex Kiselev > --- > lib/librte_lpm/rte_lpm6.c | 712 ++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 597 insertions(+), 115 deletions(-) > As with patch 1, title could do with some rewording to make it clearer the specific change and that is applies to lpm6 only. Otherwise: Acked-by: Bruce Richardson