From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0B6825F1F for ; Mon, 17 Sep 2018 18:25:01 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 09:25:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,386,1531810800"; d="scan'208";a="92476763" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.106]) by orsmga002.jf.intel.com with SMTP; 17 Sep 2018 09:24:55 -0700 Received: by (sSMTP sendmail emulation); Mon, 17 Sep 2018 17:24:53 +0100 Date: Mon, 17 Sep 2018 17:24:53 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Jingjing Wu , Wenzhuo Lu , dev@dpdk.org, Luca Boccassi Message-ID: <20180917162453.GC4520@bricha3-MOBL.ger.corp.intel.com> References: <20180913144405.72772-1-bruce.richardson@intel.com> <20180917152059.GB16172@bricha3-MOBL.ger.corp.intel.com> <9f2a9d42-2862-c5bd-8021-49198765762b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f2a9d42-2862-c5bd-8021-49198765762b@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] net/avf: remove unused variables and label X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 16:25:02 -0000 On Mon, Sep 17, 2018 at 05:12:19PM +0100, Ferruh Yigit wrote: > On 9/17/2018 4:20 PM, Bruce Richardson wrote: > > On Mon, Sep 17, 2018 at 03:53:40PM +0100, Ferruh Yigit wrote: > >> On 9/13/2018 3:44 PM, Bruce Richardson wrote: > >>> Compiling with all warnings turned on causes errors about unused variables > >>> and an unused label. Remove these to allow building without having to > >>> disable those warnings. > >> > >> If this is fixing some build errors should it be backported? > >> > >> And why we didn't get those warnings until now, aren't we already compiling with > >> all warnings turned on? > >> > >>> > >>> Signed-off-by: Bruce Richardson > >> > > It does not appear so. When we add support for building this driver with > > meson, the compiler warnings then appeared [See > > http://patches.dpdk.org/patch/44698/]. > > > > While you can backport I'm not sure it's worthwhile, unless you plan on > > backporting the new meson support too. The warnings don't come from > > external header files that apps would be using directly with unknown > > compiler flags, but are internal to DPDK and don't seem to cause any issues > > with "make" builds. > > Argh, it is missing warning flags in Makefile: > +CFLAGS += $(WERROR_FLAGS) > > When above added "make" also gives "unused variable" warnings. > > Even we don't observe the issue with current makefile, if someone builds with: > 'make EXTRA_CFLAGS="-Wunused-variable"' will observe the warnings. > > That is why I am for backporting this patch, does it make sense? > > And would you mind adding above CFLAGS update into this patch? Ok, I'll do up a V2.