From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 7B8CA200 for ; Tue, 18 Sep 2018 17:07:23 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id s15-v6so1179407pgv.8 for ; Tue, 18 Sep 2018 08:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a/+Jft4TmNOcwVZBf6c+4wJ4Jeoxfjn9gXhESDGXGJI=; b=idxHy9GFWlejvEdrWsvIpEjfjCbvwaJg8c6eOfVN2z9HBbxdKWqveEuQtDbSfOZ5q/ oY3XTBtuN1/+9eDsPKEzYu3kgAdTpEdZo6LCq/t7jsq8dpfGXz5UQZprU72IijVP5DDt o2i91HdaITfGNLufR7azIuru9/11/PFQcekJhcBmLegt4kC8ZYnsMsvtwLm6QtcWZzT/ t5zHHJH5+dwU1wuRC0wegMZmVpHXnB21pEvnTk2f0oUTGsKeVHnhLnlfKTxy6pVI1XWe BrUlOUa3EeW9Q344zm3Z4qxapaO/cEWDmlWNyhAN51lgGlB4rLe8JAYuw9pT0ACR2WTn pb6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a/+Jft4TmNOcwVZBf6c+4wJ4Jeoxfjn9gXhESDGXGJI=; b=GheKba4JuB7LRkBAn1c7QDhxyVQ141lZM2ruEHCUtxZhrAe9UtOZH9/NLJ/CAeUxim 1K8P9mzmZc4NbghrW682cT4aVlndTQ5liEE9uOFe7tAlgcY10ECHDYr0A9oqK0UlOEjP CjJzlh+SI2P9PzN3kTlio47CSw1RYgpkUzJIgMiK8d3c03CGr6bLd0ExDVV8FNh1a76B 0W+FBqm/fZw40mjmAL3j9dZU6ILtui6Ty3/P9V5oGgPfp0EceqmGv7FH7CCAgVMFUuI5 ZMfi9apLCbD0keOyce2xzNgPvLqxYgqLAVHDVUi/JXmsLsKj7+lG4sGNWGFBAjHVyEVl nVsw== X-Gm-Message-State: APzg51D5/+xhG2nhDVrBmfUeTYpkDvfJ+i0qwm5iEiHWmBqfUAcqvShT j9UnX+/SI8wKnYXcmROOpy7R3w== X-Google-Smtp-Source: ANB0VdZR4ZYr1RcNK9bdqjBDPhFbosp6lCoAGRL8uWzZm/NUzjM2iFG7l1pN3WMgybs91BjHgwS8Dg== X-Received: by 2002:a63:1125:: with SMTP id g37-v6mr28291259pgl.187.1537283242526; Tue, 18 Sep 2018 08:07:22 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p1-v6sm22159759pfn.53.2018.09.18.08.07.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 08:07:22 -0700 (PDT) Date: Tue, 18 Sep 2018 08:07:15 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Stephen Hemminger , Harish Patil , Rasesh Mody Message-ID: <20180918080715.17fcd7d8@xeon-e3> In-Reply-To: <3009159.xGyNxZp9MA@xps> References: <20180725182019.31518-1-stephen@networkplumber.org> <20180725182019.31518-3-stephen@networkplumber.org> <3009159.xGyNxZp9MA@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 15:07:23 -0000 On Tue, 18 Sep 2018 11:40:28 +0200 Thomas Monjalon wrote: > 25/07/2018 20:20, Stephen Hemminger: > > No need for profanity in comments. > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/bnx2x/elink.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c > > index 34a29373af3b..08fe817720a1 100644 > > --- a/drivers/net/bnx2x/elink.c > > +++ b/drivers/net/bnx2x/elink.c > > @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc, > > PORT_HW_CFG_E3_MOD_ABS_MASK) >> > > PORT_HW_CFG_E3_MOD_ABS_SHIFT; > > > > - /* Should not happen. This function called upon interrupt > > + /* > > + * Should not happen. This function called upon interrupt > > * triggered by GPIO ( since EPIO can only generate interrupts > > * to MCP). > > * So if this function was called and none of the GPIOs was set, > > - * it means the shit hit the fan. > > */ > > It makes the comment ends with a comma, like the end is missing. > > > Yes, better language would be. /* This should not happen since this function is called * from interrupt triggered by GPI ..