From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 5FB234F90 for ; Wed, 19 Sep 2018 17:04:53 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id s12-v6so6669649wmc.0 for ; Wed, 19 Sep 2018 08:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hcDqZK8Fc0rYXRWol9IIU+9WaAPz8RioncAIygvBu6Y=; b=XMtcTnXaFeBlLF4nZNrmD3cVCO+6tOdl8cCCN2mxld5QgkbeTBD2cMaTFSJm5SkVIC FgPCQpBgjxAwadwWiAXm0hvKiEPsSW7s+LCS7efuCjmFpJaXnpxqpynjQSPxONWHI4Nb jJAyVj/okRzo3FkY6kmmwQl7woARIPDiZFm7VjRkjblhZmTiuw791lpgjvrDaDVQ7GxZ lI8i+Cl9OpbPfRnwShHUiwLMmqdPDCxQ46WiWxzVcThzuq2H7DD66XkkkI2X+Id6XR9+ 2611dN6sobnHpUCjBB+Rn5x5o9PQjOVpJSU92ExI2qh2f/AVbxNvT9LygGokxp07iUxU 1tUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hcDqZK8Fc0rYXRWol9IIU+9WaAPz8RioncAIygvBu6Y=; b=sduzHBNgUONblibJoSLXKzYTyVfExS9aV72AV7OXgy9zOhdIVghN/SWH82t3R0As9W SWIeQw4zC9cMslg9AOWzx7lMARJRwF/fBv2pG6GK8A6JAiX1PpOX6XdU8nb3XQ2zFBmb b9PosmffJzYSLXrh+IQ54bkzClk+AneqJteS9G430dGbko7KTOCWmRaJGKrszSuEAZXk W4TZrNnAtljxNp1eJj+yj2lGfE0n/93IKeI2gs1mgsbQt8eNreDn/8edlhUk92L8SDDW QviQ/HGKHD7iHVQDwSpn16Cdrpw+as5HKtQFMKDuEoan9XnmBBYQioUAPmly6Bg2LAqQ 2lVg== X-Gm-Message-State: APzg51B1pbOVuhrXzyX+LWAEDh9RCGfIH4rIeG+rrqgYMHUAxTI27ElT BQBBeAt5UYy58jmX4zOdeKUpckbjxBTHrg== X-Google-Smtp-Source: ANB0VdZ6jR9B2RGYQojbjf9roJgi0XKdA0QmvmDKA9SJqfRTqcoMAEEvBbBel0H0sB/ys887iTFL5w== X-Received: by 2002:a1c:a614:: with SMTP id p20-v6mr21311284wme.68.1537369492867; Wed, 19 Sep 2018 08:04:52 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:52 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:07 +0200 Message-Id: <20180919150409.22880-3-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 2/4] net/fm10k: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 15:04:53 -0000 In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in fm10k. Fixes: 30f3ce999e6a ("net/fm10k: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 3359df3c8b9c..7cf5b0314c75 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1975,6 +1975,7 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev) RTE_SET_USED(dev); return (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM | -- 2.11.0