Re: [dpdk-dev] [PATCH v2 1/2] vhost: introduce API to get vDPA device number

[Ye Xiaolong <xiaolong.ye@intel.com>]

On 09/19, Wang, Xiao W wrote:
>Hi,
>
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, September 14, 2018 2:07 AM
>> To: dev@dpdk.org; Maxime Coquelin <maxime.coquelin@redhat.com>; Bie,
>> Tiwei <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>
>> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; Rami Rosen
>> <roszenrami@gmail.com>; Wang, Haiyue <haiyue.wang@intel.com>; Ye,
>> Xiaolong <xiaolong.ye@intel.com>
>> Subject: [PATCH v2 1/2] vhost: introduce API to get vDPA device number
>> 
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>>  lib/librte_vhost/rte_vdpa.h | 3 +++
>>  lib/librte_vhost/vdpa.c     | 6 ++++++
>>  2 files changed, 9 insertions(+)
>> 
>> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
>> index 90465ca26..b8223e337 100644
>> --- a/lib/librte_vhost/rte_vdpa.h
>> +++ b/lib/librte_vhost/rte_vdpa.h
>> @@ -84,4 +84,7 @@ rte_vdpa_find_device_id(struct rte_vdpa_dev_addr
>> *addr);
>>  struct rte_vdpa_device * __rte_experimental
>>  rte_vdpa_get_device(int did);
>
>add it also to *version.map, so that we can link it as shared lib.

Got it.

>
>> 
>> +/* Get current available vdpa device number */
>> +int __rte_experimental
>> +rte_vdpa_get_device_num(void);
>>  #endif /* _RTE_VDPA_H_ */
>> diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
>> index c82fd4370..c2c5dff1d 100644
>> --- a/lib/librte_vhost/vdpa.c
>> +++ b/lib/librte_vhost/vdpa.c
>> @@ -113,3 +113,9 @@ rte_vdpa_get_device(int did)
>> 
>>  	return vdpa_devices[did];
>>  }
>> +
>> +int
>> +rte_vdpa_get_device_num(void)
>> +{
>> +	return vdpa_device_num;
>> +}
>> --
>> 2.17.1
>
>It's better to have a cover letter for a patch set.

Got it, will sent out a cover letter in next iteration.

Thanks,
Xiaolong
>
>BRs,
>Xiao
>