DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, xuemingx.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables
Date: Thu, 20 Sep 2018 12:25:28 +0100	[thread overview]
Message-ID: <20180920112528.GB19844@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <df80f028e6cb329ca4982989d8b8f43e685637b6.1537435899.git.anatoly.burakov@intel.com>

On Thu, Sep 20, 2018 at 10:34:46AM +0100, Anatoly Burakov wrote:
> Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---

Sorry, I missed your patch by about 1 hour - hadn't got through my mail
fully when sent mine.
I think you could do with a couple of other fixes tags on it, just take
them from my patch. Otherwise:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

>  lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
> index 06afbcc99..a5847f0bd 100644
> --- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
> @@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void)
>  }
>  
>  int
> -eal_memalloc_get_seg_fd(int list_idx, int seg_idx)
> +eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused)
>  {
>  	return -ENOTSUP;
>  }
>  
>  int
> -eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd)
> +eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused,
> +		int fd __rte_unused)
>  {
>  	return -ENOTSUP;
>  }
>  
>  int
> -eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset)
> +eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused,
> +		int seg_idx __rte_unused, size_t *offset __rte_unused)
>  {
>  	return -ENOTSUP;
>  }
> -- 
> 2.17.1

  reply	other threads:[~2018-09-20 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20  9:34 Anatoly Burakov
2018-09-20 11:25 ` Bruce Richardson [this message]
2018-09-20 11:29   ` Burakov, Anatoly
2018-09-20 12:26 ` [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error Anatoly Burakov
2018-09-20 12:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920112528.GB19844@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xuemingx.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).