From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4465A326C for ; Thu, 20 Sep 2018 13:25:33 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 04:25:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,398,1531810800"; d="scan'208";a="93377455" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga002.jf.intel.com with SMTP; 20 Sep 2018 04:25:29 -0700 Received: by (sSMTP sendmail emulation); Thu, 20 Sep 2018 12:25:29 +0100 Date: Thu, 20 Sep 2018 12:25:28 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net, xuemingx.zhang@intel.com Message-ID: <20180920112528.GB19844@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 11:25:33 -0000 On Thu, Sep 20, 2018 at 10:34:46AM +0100, Anatoly Burakov wrote: > Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd") > > Signed-off-by: Anatoly Burakov > --- Sorry, I missed your patch by about 1 hour - hadn't got through my mail fully when sent mine. I think you could do with a couple of other fixes tags on it, just take them from my patch. Otherwise: Acked-by: Bruce Richardson > lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c > index 06afbcc99..a5847f0bd 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c > +++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c > @@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void) > } > > int > -eal_memalloc_get_seg_fd(int list_idx, int seg_idx) > +eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused) > { > return -ENOTSUP; > } > > int > -eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd) > +eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused, > + int fd __rte_unused) > { > return -ENOTSUP; > } > > int > -eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset) > +eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused, > + int seg_idx __rte_unused, size_t *offset __rte_unused) > { > return -ENOTSUP; > } > -- > 2.17.1