Re: [dpdk-dev] [PATCH v4 1/5] eventdev: add eth Tx adapter APIs

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Thu, 20 Sep 2018 23:11:12 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com,
>  marko.kovacevic@intel.com, john.mcnamara@intel.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>
> Subject: [PATCH v4 1/5] eventdev: add eth Tx adapter APIs
> X-Mailer: git-send-email 1.8.3.1
> 
> The ethernet Tx adapter abstracts the transmit stage of an
> event driven packet processing application. The transmit
> stage may be implemented with eventdev PMD support or use a
> rte_service function implemented in the adapter. These APIs
> provide a common configuration and control interface and
> an transmit API for the eventdev PMD implementation.
> 
> The transmit port is specified using mbuf::port. The transmit
> queue is specified using the rte_event_eth_tx_adapter_txq_set()
> function.
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  lib/librte_eventdev/rte_event_eth_tx_adapter.h | 462 +++++++++++++++++++++++++
>  lib/librte_mbuf/rte_mbuf.h                     |   5 +-
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index a50b05c..b47a5c5 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -464,7 +464,9 @@ struct rte_mbuf {
>         };
>         uint16_t nb_segs;         /**< Number of segments. */
> 
> -       /** Input port (16 bits to support more than 256 virtual ports). */
> +       /** Input port (16 bits to support more than 256 virtual ports).
> +        * The event eth Tx adapter uses this field to specify the output port.
> +        */
>         uint16_t port;
> 
>         uint64_t ol_flags;        /**< Offload features. */
> @@ -530,6 +532,7 @@ struct rte_mbuf {
>                 struct {
>                         uint32_t lo;
>                         uint32_t hi;
> +                       /**< @see rte_event_eth_tx_adapter_txq_set */
>                 } sched;          /**< Hierarchical scheduler */
>                 uint32_t usr;     /**< User defined tags. See rte_distributor_process() */
>         } hash;                   /**< hash information */

Olivier,

I am planning to take this patch into next-eventdev tree. Could you
please let us know, if you any comments on above "comments" additions to
lib/librte_mbuf/rte_mbuf.h.

If there is any minor one, I can do it on apply or if it major one
Nikhil can send the next version. Let us know.

/Jerin