From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 871FCF04 for ; Fri, 21 Sep 2018 14:16:40 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id j15-v6so8563185wrt.8 for ; Fri, 21 Sep 2018 05:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=BBPX34GF1YR3386JJSz5OHqYa5JPNphpE/5jvRZfnoY=; b=wy9Iif5N6liszsDMj8mYuymX2/50RbfZ4W2rMngMLtzwqkHLY7ItQIQU1VuYJGL0ys ETsL0FpwFiKDVa13dqqCQqVzyHMwwSCGLr8rGY+M8/ThAqjVpkSEit6Efb6HL3H76MgN EEFMJNQO3fpUmZQr9JdDRvPO/ahBZ1AIDc8NW8oFtoj76aNSe8Pv7xD4g16q+h4WPdvO SlFUtBr+5H9BtTb1O/evVos70Iz4FZcq+08VqPfeakKqpmU8xWFREspGfCc2BAqXBwYG Aiykkl9CD8RDANxnidyBsrg63PFF+oczVMTzCuj+k96sNdZeo0SD+tKaLlyXRr7HsfkB 1BKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=BBPX34GF1YR3386JJSz5OHqYa5JPNphpE/5jvRZfnoY=; b=uSRdkPA9nm6+Pq5VddJPiT+eoWkoARr1/xkxiaZdmT+olMmCbtd+gFus3nycfH0ubC hGLSdBhB+yRHHg2hlcI824i6CHW//XNdrjNPRjx93HGa9YXrRHMirSWbYWc/KYPp850K 5PlfZWoUNx9Z00qmptAsJjvFjV3sW+q5CJO3DfqZ1XPDyKQpQcPHbhadqqvHVF2JWxAK Vp7kpKNUPVMrob3anu1MOFOCuNhn3SbfqKkUUS/gQgNBr6u+X6bShz1qBb8gzOVO1SEi 2o8cYR6Q+BAQSNWTDU5LKurmjLE49UaLOdIHirp2gf66O8+CbTAJL2jT9nHjCN6hTnH9 U+vQ== X-Gm-Message-State: ABuFfogLltxrUtTHGw9XbdUT3RJAROUTB92U55p4O5ybkFDRL1iXMPEf UEUNE+h7Ks5YXkAA1qOrDUxhcO9juOg= X-Google-Smtp-Source: ACcGV61y0k0U4ucGFw2ekG7uoopGk4GDtrpckzSL+i2oOmYgeJZDk15tnkn0aCpMtoHG0ULWnT9nRA== X-Received: by 2002:adf:f0d1:: with SMTP id x17-v6mr9501295wro.49.1537532199659; Fri, 21 Sep 2018 05:16:39 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r13-v6sm4597557wmf.35.2018.09.21.05.16.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Sep 2018 05:16:38 -0700 (PDT) Date: Fri, 21 Sep 2018 14:16:21 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org, arybchenko@solarflare.com Message-ID: <20180921121621.rjo7esvng7gjuri4@bidouze.vm.6wind.com> References: <6077733.FS8kXFb8lC@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6077733.FS8kXFb8lC@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 07/13] ethdev: add device matching field name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 12:16:40 -0000 On Thu, Sep 20, 2018 at 06:17:13PM +0200, Thomas Monjalon wrote: > 19/09/2018 18:03, Gaetan Rivet: > > The eth device class can now parse a field name, > > matching the eth_dev name with one passed as > > > > "class=eth,name=xxxxxx" > > I am not sure what is the purpose of the "name" property. > I think we should not need it to choose a port by its ethdev name. rte_eth_dev_get_port_by_name seems pretty close. Which fields do you think should be proposed first as a getter on the eth class? Or do you have a list of fields the eth class should be restricted to? > If you are thinking about a vdev, we can use the rte_device name (at bus level). This patch is only about eth class, it has no impact on buses. -- Gaëtan Rivet 6WIND