From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 526D64CA6 for ; Mon, 24 Sep 2018 16:42:16 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 07:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,298,1534834800"; d="scan'208";a="94360950" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207]) by orsmga002.jf.intel.com with ESMTP; 24 Sep 2018 07:42:13 -0700 Date: Tue, 25 Sep 2018 05:30:23 +0800 From: Ye Xiaolong To: "Wang, Xiao W" Cc: "dev@dpdk.org" , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , Rami Rosen , "Wang, Haiyue" Message-ID: <20180924213023.GA94886@intel.com> References: <20180920222817.45829-1-xiaolong.ye@intel.com> <20180924084248.91811-1-xiaolong.ye@intel.com> <20180924084248.91811-3-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 2/2] examples/vdpa: introduce a new sample for vDPA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 14:42:16 -0000 On 09/24, Wang, Xiao W wrote: >Hi Xiaolong, > >Thanks for the update, 2 small comments below. > [snip] >> + ./vdpa --log-level=9 -c 0x6 -n 4 --socket-mem 1024,1024 \ >> + -w 0000:06:00.3,vdpa=1 -w 0000:06:00.4,vdpa=1 \ >> + -- --interactive > >To demonstrate app doesn't need to launch dedicated worker threads for vhost enqueue/dequeue operations, >We can use "-c 0x2" to indicate that no need to allocate dedicated worker threads. > Got it, will do. >> + >> +.. note:: [snip] >> "%d\t\t"PCI_PRI_FMT"\t%"PRIu32"\t\t0x%"PRIu64"\n", did, >> + addr.domain, addr.bus, addr.devid, >> + addr.function, queue_num, features); > >Use PRIx64 instead of PRIu64 for features. >You can add a blank space between "PRIx64" and the other section to make it more readable. >Refer to: > lib/librte_vhost/vhost_user.c: "guest memory region %u, size: 0x%" PRIx64 "\n" Got it, will do. Thanks, Xiaolong > >BRs, >Xiao