DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, jianbo.liu@arm.com,
	gavin.hu@arm.com
Subject: Re: [dpdk-dev] [PATCH v3 1/3] lib/librte_table: add hash_func header files
Date: Tue, 25 Sep 2018 10:12:29 +0530	[thread overview]
Message-ID: <20180925044228.GA21250@jerin> (raw)
In-Reply-To: <20180907100626.8165-1-kevin.laatz@intel.com>

-----Original Message-----
> Date: Fri, 7 Sep 2018 11:06:24 +0100
> From: Kevin Laatz <kevin.laatz@intel.com>
> To: dev@dpdk.org
> CC: cristian.dumitrescu@intel.com, jianbo.liu@arm.com, gavin.hu@arm.com,
>  jerin.jacob@caviumnetworks.com, Kevin Laatz <kevin.laatz@intel.com>
> Subject: [PATCH v3 1/3] lib/librte_table: add hash_func header files
> X-Mailer: git-send-email 2.9.5
> 
> This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h to
> librte_table. This reduces code duplication by removing duplicate header files
> within two folders and consolidating them into a single one. This also adds a
> scalar implementation of the x86_64 intrinsic for crc32 as a generic fallback.
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Acked-by: Gavin Hu <gavin.hu@arm.com>
> ---
> v2:
>    - Fixed typo in commit message
>    - Fixed typo in arm header that caused some compilations to fail for the
>      entire patchset
> v3:
>    - Improved commit message

ARM specific change and this patchset looks good. But, It has following
checkpatches.sh and check-git-log.sh errors.

➜ [master][dpdk.org] $ ./devtools/checkpatches.sh 

### lib/librte_table: add hash_func header files

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#7: 
librte_table. This reduces code duplication by removing duplicate header
files

total: 0 errors, 1 warnings, 298 lines checked
ERROR: symbol rte_crc32_u64_generic is added in a section other than the
EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key16 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key24 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key32 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key40 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key48 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key56 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key64 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key8 is added in a section other than
the EXPERIMENTAL section of the version map

2/3 valid patches
➜ [master][dpdk.org] $ ./devtools/check-git-log.sh 
Wrong headline format:
	lib/librte_table: add hash_func header files
	examples/ip_pipeline: modify application to use librte_table
headers
	net/softnic: modify softnic to use librte_table headers
Headline too long:
	examples/ip_pipeline: modify application to use librte_table
headers
Line too long:
	librte_table. This reduces code duplication by removing
duplicate header files
	within two folders and consolidating them into a single one.
This also adds a
	scalar implementation of the x86_64 intrinsic for crc32 as a
generic fallback.

  parent reply	other threads:[~2018-09-25  4:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 10:06 Kevin Laatz
2018-09-07 10:06 ` [dpdk-dev] [PATCH v3 2/3] examples/ip_pipeline: modify application to use librte_table headers Kevin Laatz
2018-09-07 10:20   ` Gavin Hu (Arm Technology China)
2018-09-07 10:06 ` [dpdk-dev] [PATCH v3 3/3] net/softnic: modify softnic " Kevin Laatz
2018-09-07 10:20   ` Gavin Hu (Arm Technology China)
2018-09-25  4:42 ` Jerin Jacob [this message]
2018-09-25  9:15   ` [dpdk-dev] [PATCH v3 1/3] lib/librte_table: add hash_func header files Dumitrescu, Cristian
2018-09-25 15:32 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_table: add hash func " Kevin Laatz
2018-09-25 15:32   ` [dpdk-dev] [PATCH v4 2/3] examples/ip_pipeline: modify to use new table lib headers Kevin Laatz
2018-09-25 16:27     ` Jerin Jacob
2018-09-25 15:32   ` [dpdk-dev] [PATCH v4 3/3] net/softnic: " Kevin Laatz
2018-09-25 16:28     ` Jerin Jacob
2018-09-25 16:25   ` [dpdk-dev] [PATCH v4 1/3] lib/librte_table: add hash func header files Jerin Jacob
2018-09-28 10:34   ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925044228.GA21250@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=jianbo.liu@arm.com \
    --cc=kevin.laatz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).