Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Tue, 25 Sep 2018 11:50:06 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Nikhil Rao <nikhil.rao@intel.com>, dev@dpdk.org, stable@dpdk.org
> Subject: Re: [PATCH v2] eventdev: fix port id argument in Rx adapter caps
>  API
> 
> 
> 25/09/2018 11:15, Jerin Jacob:
> > -----Original Message-----
> > > Date: Tue, 25 Sep 2018 14:19:12 +0530
> > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > To: jerin.jacob@caviumnetworks.com
> > > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API
> > > X-Mailer: git-send-email 1.8.3.1
> > >
> > >
> > > Make the ethernet port id passed into
> > > rte_event_eth_rx_adapter_caps_get() 16 bit.
> > >
> > > Also, update the event rx adapter test to use 16 bit
> > > ethernet port ids.
> > >
> > > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > >
> > > v2:
> > > * squash changes to autotest and library into a single patch (Jerin Jacob)
> > > * add update to release notes (Jerin Jacob)
> > >
> > >  lib/librte_eventdev/rte_eventdev.h     | 2 +-
> > >  lib/librte_eventdev/rte_eventdev.c     | 2 +-
> > >  test/test/test_event_eth_rx_adapter.c  | 6 +++---
> > >  doc/guides/rel_notes/release_18_11.rst | 4 +++-
> > >  lib/librte_eventdev/Makefile           | 2 +-
> >
> > Missing version update in lib/librte_eventdev/meson.build. See version=
> >
> > >  5 files changed, 9 insertions(+), 7 deletions(-)
> > >
> > >  ABI Changes
> > >  -----------
> > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
> > >       librte_distributor.so.1
> > >       librte_eal.so.8
> > >       librte_ethdev.so.10
> > > -     librte_eventdev.so.4
> > > +   + librte_eventdev.so.6
> >
> > Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst
> > release notes. The version(change to librte_eventdev.so.5) should have been
> > updated in change set in 3810ae4357.
> >
> > +Thomas,
> > In case if he has difference in opinion on updating released release note file.
> 
> I prefer such changes being atomic.

Me too. But the offending change set(3810ae4357) is old
➜ [master][dpdk.org] $ git describe  3810ae4357
v18.05-389-g3810ae435

Do you prefer to have patch to update the release_18_08.rst file or ignore it?


> 
>