From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Igor Romanov <Igor.Romanov@oktetlabs.ru>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: limit device capabilities to really supported
Date: Tue, 25 Sep 2018 17:48:11 +0200 [thread overview]
Message-ID: <20180925154811.4bhiybd24vwb772y@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1535528736-31325-1-git-send-email-arybchenko@solarflare.com>
Hi,
Sorry I had forgotten this one.
I would rename the title, something like:
net/failsafe: report actual device capabilities
And a few edits in the commit log:
On Wed, Aug 29, 2018 at 08:45:36AM +0100, Andrew Rybchenko wrote:
> From: Igor Romanov <Igor.Romanov@oktetlabs.ru>
>
> Failsafe driver does not support any device capabilities yet.
> Make fs_dev_infos_get() consider default ones to limit advertised
^^^^^^^^=report
> device capabilities to really supported instead of unconditional
| ^^^^^=actually? ^^^^^^^^^^^^^^^^^^^^^^^^
^ +those?
> inheritance from sub-devices.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -> whole end of sentence can be removed.
>
> Fixes: cac923cfea47 ("ethdev: support runtime queue setup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <Igor.Romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Otherwise
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_ops.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
> index 24e91c931..2df8b55d9 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -716,6 +716,8 @@ fs_stats_reset(struct rte_eth_dev *dev)
> * all sub_devices and the default capabilities.
> * Uses a logical AND of TX capabilities among
> * the active probed sub_device and the default capabilities.
> + * Uses a logical AND of device capabilities among
> + * all sub_devices and the default capabilities.
> *
> */
> static void
> @@ -734,10 +736,12 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
> uint64_t rx_offload_capa;
> uint64_t rxq_offload_capa;
> uint64_t rss_hf_offload_capa;
> + uint64_t dev_capa;
>
> rx_offload_capa = default_infos.rx_offload_capa;
> rxq_offload_capa = default_infos.rx_queue_offload_capa;
> rss_hf_offload_capa = default_infos.flow_type_rss_offloads;
> + dev_capa = default_infos.dev_capa;
> FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {
> rte_eth_dev_info_get(PORT_ID(sdev),
> &PRIV(dev)->infos);
> @@ -746,12 +750,14 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
> PRIV(dev)->infos.rx_queue_offload_capa;
> rss_hf_offload_capa &=
> PRIV(dev)->infos.flow_type_rss_offloads;
> + dev_capa &= PRIV(dev)->infos.dev_capa;
> }
> sdev = TX_SUBDEV(dev);
> rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos);
> PRIV(dev)->infos.rx_offload_capa = rx_offload_capa;
> PRIV(dev)->infos.rx_queue_offload_capa = rxq_offload_capa;
> PRIV(dev)->infos.flow_type_rss_offloads = rss_hf_offload_capa;
> + PRIV(dev)->infos.dev_capa = dev_capa;
> PRIV(dev)->infos.tx_offload_capa &=
> default_infos.tx_offload_capa;
> PRIV(dev)->infos.tx_queue_offload_capa &=
> --
> 2.17.1
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2018-09-25 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:45 Andrew Rybchenko
2018-09-25 15:48 ` Gaëtan Rivet [this message]
2018-09-26 6:36 ` Andrew Rybchenko
2018-09-26 6:38 ` [dpdk-dev] [PATCH v2] net/failsafe: report actual device capabilities Andrew Rybchenko
2018-09-26 11:58 ` Gaëtan Rivet
2018-10-01 14:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925154811.4bhiybd24vwb772y@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=Igor.Romanov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).