From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id B08395F25 for ; Tue, 25 Sep 2018 17:48:29 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id s12-v6so13999186wmc.0 for ; Tue, 25 Sep 2018 08:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YJYTBASC7N5E8yNvm/Ng2MywenuZiw22vyNjPkkJF+c=; b=TWo6VDKDPYWuXq8ANFDLmhgoa20C+9Ue4odwt9WkbO1nMwKvBA1IY4AAy4DZPLf8GN 06j7LVnhg8eYR7ad18ToajJrJnsNYxNAJlnfnXSSzh9wZ7FE3p+H0OUhVqYlwvOMiZz2 ZVCmmtN3GZWZG/eYhvpJVpkCWV4ztmxoZAoDfOQSgMIvF2MbmmrVYhXeFRfCoXo5MzOq QZ9FWFXMqJ5vr5IvphdZitVrETXdozU3jJINPQ4O4MvXTQfNuzKkDHei0jpqKqiOe2Hy t2QS9uGSUed4YjRWufToZmFAMyiJS7R6g/BaKPm/mhfdT8R8/hilrgR+fezQt/Qxk5u8 4VrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YJYTBASC7N5E8yNvm/Ng2MywenuZiw22vyNjPkkJF+c=; b=ON2Rdh9QbnqNUy4TwLR5bZjs/POfsQyAP80YaYKuMh50GNdllPYkq4uPYCHVBrlxRI pWBSHRYdeEGAf98lRgpXBfIPc55idL07E3blD+XbUwV0FvXVBjBZCNX13qAJ+9oPiKm4 EHRpA9N//onUzHuHvJEJJbmxKXCoidXNXrEaXPrsnSUJGz2apCVSvGcA02uVHB+ot7it 5o8UV6gn8++mmSP2uCN8ZvtNUKm53SysnOll5HcSfYUijhC3jQDEJW7OlxMb6tB8NOK9 ny+Uo/8m1ncRGJAjHI7rF5MblIwe7F1m380dXA1syxFuENK/atF2ZfZJnB3BPMYR5xde iQzg== X-Gm-Message-State: ABuFfohlYmeyjMVVKUFvHpWeg1gBv7L6x5wGuOFnJkg/y9LaZowi8sFp gxJMR0lOWV3AERjexlY1mrbb/A== X-Google-Smtp-Source: ACcGV63mAID1mf5691XFVuFT3H0H4VdDUp9WDKU3CQu7n8gGCOY7TDdgWF53PG6YNyZthXgyUbDx6w== X-Received: by 2002:a1c:b143:: with SMTP id a64-v6mr1286433wmf.109.1537890509217; Tue, 25 Sep 2018 08:48:29 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c15-v6sm1745593wmb.2.2018.09.25.08.48.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Sep 2018 08:48:28 -0700 (PDT) Date: Tue, 25 Sep 2018 17:48:11 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Andrew Rybchenko Cc: dev@dpdk.org, Igor Romanov , stable@dpdk.org Message-ID: <20180925154811.4bhiybd24vwb772y@bidouze.vm.6wind.com> References: <1535528736-31325-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1535528736-31325-1-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/failsafe: limit device capabilities to really supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 15:48:29 -0000 Hi, Sorry I had forgotten this one. I would rename the title, something like: net/failsafe: report actual device capabilities And a few edits in the commit log: On Wed, Aug 29, 2018 at 08:45:36AM +0100, Andrew Rybchenko wrote: > From: Igor Romanov > > Failsafe driver does not support any device capabilities yet. > Make fs_dev_infos_get() consider default ones to limit advertised ^^^^^^^^=report > device capabilities to really supported instead of unconditional | ^^^^^=actually? ^^^^^^^^^^^^^^^^^^^^^^^^ ^ +those? > inheritance from sub-devices. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -> whole end of sentence can be removed. > > Fixes: cac923cfea47 ("ethdev: support runtime queue setup") > Cc: stable@dpdk.org > > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko Otherwise Acked-by: Gaetan Rivet > --- > drivers/net/failsafe/failsafe_ops.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > index 24e91c931..2df8b55d9 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -716,6 +716,8 @@ fs_stats_reset(struct rte_eth_dev *dev) > * all sub_devices and the default capabilities. > * Uses a logical AND of TX capabilities among > * the active probed sub_device and the default capabilities. > + * Uses a logical AND of device capabilities among > + * all sub_devices and the default capabilities. > * > */ > static void > @@ -734,10 +736,12 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > uint64_t rx_offload_capa; > uint64_t rxq_offload_capa; > uint64_t rss_hf_offload_capa; > + uint64_t dev_capa; > > rx_offload_capa = default_infos.rx_offload_capa; > rxq_offload_capa = default_infos.rx_queue_offload_capa; > rss_hf_offload_capa = default_infos.flow_type_rss_offloads; > + dev_capa = default_infos.dev_capa; > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { > rte_eth_dev_info_get(PORT_ID(sdev), > &PRIV(dev)->infos); > @@ -746,12 +750,14 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > PRIV(dev)->infos.rx_queue_offload_capa; > rss_hf_offload_capa &= > PRIV(dev)->infos.flow_type_rss_offloads; > + dev_capa &= PRIV(dev)->infos.dev_capa; > } > sdev = TX_SUBDEV(dev); > rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); > PRIV(dev)->infos.rx_offload_capa = rx_offload_capa; > PRIV(dev)->infos.rx_queue_offload_capa = rxq_offload_capa; > PRIV(dev)->infos.flow_type_rss_offloads = rss_hf_offload_capa; > + PRIV(dev)->infos.dev_capa = dev_capa; > PRIV(dev)->infos.tx_offload_capa &= > default_infos.tx_offload_capa; > PRIV(dev)->infos.tx_queue_offload_capa &= > -- > 2.17.1 > -- Gaëtan Rivet 6WIND