From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id 6DA771B133 for ; Wed, 26 Sep 2018 11:31:16 +0200 (CEST) Received: by mail-ed1-f67.google.com with SMTP id j62-v6so1267997edd.7 for ; Wed, 26 Sep 2018 02:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=mObjsn17rqa0QVC0xzp0s2/10xHsMMwerg3knKYAx8Q=; b=sYg46O2L9gnifwaZ/S+Y6GQ1ykNodbXWlUJn7rXt7Ofd6oiamj5cCJNJWuZ3ESpfKr /M4q4ciZq8V6USD3950QikfhTlws6Ojn+X40LQPY+1zZjK/TeB6jzOzbXRMS1DzUJqN6 EG/79tTFpVBvmOm4aymj+A2hS1X/igfm8P8+i5DsvlH+GJjc7h+59/3ldcpShsCbtG/v H6+xBA75h28hpelCPWqg76fAcZ1MtKP+U7wLrWmOGVNZq6I/4Qx5u4Qi4g51K3cxx+bK /AdUZGocw0rdECZqL1VFoZbCvnVoyxknB6gNReqyzKXbJYUX6Cu681wbf8F3c0RH/+ig X7tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mObjsn17rqa0QVC0xzp0s2/10xHsMMwerg3knKYAx8Q=; b=J8ZHvf0KcStcjWZq/Gu0Oj+D2K9FIA1phHKTJxZtBcEGOeWhXwNr4TCITQWy+K3a1v wals3oVli+aWmUlBLHFlJGcWMUJWEmFFr4wdeeGIzr4gxud78C5ae00qnWetsYy6kfnR noB7gtVw0FbYgunblDNIDdJHJOu6kxYVeYyr1A1xJabo2tCvVOwvr5VZU/2E8s2+6KQL TZB6TNFBNmASM7BHeCcBRiavW+J8y3PDXLxPgtXC9nvM3f6ojPrXUMFPi7ry7MhxPCqi ggVt29DBUjYFPLe8oKNy3bGmupLKJBI0kOi5MCB1o2+s/wXUVH8u9vrCWM0jgIS3Cb0w pxWw== X-Gm-Message-State: ABuFfohDvpuL36xqfhOPwNhjFQVsIrlQVNlTd3L7La01MQm30bgs4I0j AchuGgoKoy8rhuU7J7n4QjraD2uFfx8I+Q== X-Google-Smtp-Source: ACcGV60lFs/xYRDOr10+k6rqzs/CEmBuiTvi5fpOc3xFoSlNZzlzN7J7I+LoAuKnCWzh+sEhvLzrUg== X-Received: by 2002:a50:9471:: with SMTP id q46-v6mr8291824eda.70.1537954275658; Wed, 26 Sep 2018 02:31:15 -0700 (PDT) Received: from localhost.localdomain ([213.244.170.154]) by smtp.gmail.com with ESMTPSA id l30-v6sm11437715edc.70.2018.09.26.02.31.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Sep 2018 02:31:14 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 26 Sep 2018 10:31:12 +0100 Message-Id: <20180926093112.24235-1-sthemmin@microsoft.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 09:31:16 -0000 Should check return value from processing latency value. Coverity issue: 322104 Signed-off-by: Stephen Hemminger --- Patch against dpdk-next-net drivers/net/netvsc/hn_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index b67cce1ba8f5..8845fc0e6176 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -167,6 +167,7 @@ static int hn_parse_args(const struct rte_eth_dev *dev) NULL }; struct rte_kvargs *kvlist; + int ret; if (!devargs) return 0; @@ -180,9 +181,12 @@ static int hn_parse_args(const struct rte_eth_dev *dev) return -EINVAL; } - rte_kvargs_process(kvlist, "latency", hn_set_latency, hv); + ret = rte_kvargs_process(kvlist, "latency", hn_set_latency, hv); + if (ret) + PMD_DRV_LOG(ERR, "Unable to process latency arg\n"); + rte_kvargs_free(kvlist); - return 0; + return ret; } /* Update link status. -- 2.17.1