From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D02441B136 for ; Wed, 26 Sep 2018 12:04:46 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 03:04:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,305,1534834800"; d="scan'208";a="77392579" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga006.jf.intel.com with SMTP; 26 Sep 2018 03:04:43 -0700 Received: by (sSMTP sendmail emulation); Wed, 26 Sep 2018 11:04:42 +0100 Date: Wed, 26 Sep 2018 11:04:42 +0100 From: Bruce Richardson To: Yipeng Wang Cc: dev@dpdk.org, michel@digirati.com.br, honnappa.nagarahalli@arm.com Message-ID: <20180926100441.GA20648@bricha3-MOBL.ger.corp.intel.com> References: <1536253745-133104-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-2-git-send-email-yipeng1.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537550255-252066-2-git-send-email-yipeng1.wang@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 10:04:47 -0000 On Fri, Sep 21, 2018 at 10:17:29AM -0700, Yipeng Wang wrote: > The bucket size was changed from 4 to 8 but the corresponding > perf test was not changed accordingly. > Can you perhaps give a little detail on what actual problems this caused. Did it just mean that we used up too much memory in the test because we thought there were more buckets than there were, or something else? > Fixes: 58017c98ed53 ("hash: add vectorized comparison") > Cc: stable@dpdk.org > > Signed-off-by: Yipeng Wang > --- > test/test/test_hash_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c > index 33dcb9f..9ed7125 100644 > --- a/test/test/test_hash_perf.c > +++ b/test/test/test_hash_perf.c > @@ -20,7 +20,7 @@ > #define MAX_ENTRIES (1 << 19) > #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ > #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */ > -#define BUCKET_SIZE 4 > +#define BUCKET_SIZE 8 > #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) > #define MAX_KEYSIZE 64 > #define NUM_KEYSIZES 10 > -- > 2.7.4 >