From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3D0CF1B17F for ; Wed, 26 Sep 2018 13:13:09 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 04:13:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208";a="72995587" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga007.fm.intel.com with SMTP; 26 Sep 2018 04:13:06 -0700 Received: by (sSMTP sendmail emulation); Wed, 26 Sep 2018 12:13:05 +0100 Date: Wed, 26 Sep 2018 12:13:05 +0100 From: Bruce Richardson To: Yipeng Wang Cc: dev@dpdk.org, michel@digirati.com.br, honnappa.nagarahalli@arm.com Message-ID: <20180926111304.GD20648@bricha3-MOBL.ger.corp.intel.com> References: <1536253745-133104-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-4-git-send-email-yipeng1.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537550255-252066-4-git-send-email-yipeng1.wang@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 3/7] test/hash: fix rw test with non-consecutive cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 11:13:10 -0000 On Fri, Sep 21, 2018 at 10:17:31AM -0700, Yipeng Wang wrote: > the multi-reader and multi-writer rte_hash unit test does not > work correctly with non-consicutive core ids. This commit > fixes the issue. > > Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") > Cc: stable@dpdk.org > > Signed-off-by: Yipeng Wang > --- > test/test/test_hash_readwrite.c | 78 ++++++++++++++++++++++++++--------------- > 1 file changed, 49 insertions(+), 29 deletions(-) > With existing code, testing with "-l 0,2,4,6,40,42,44,48" gives error: ++++++++Start function tests:+++++++++ Core #2 inserting and reading 1966080: 3,932,160 - 5,898,240 Core #4 inserting and reading 1966080: 7,864,320 - 9,830,400 Core #6 inserting and reading 1966080: 11,796,480 - 13,762,560 Core #40 inserting and reading 1966080: 78,643,200 - 80,609,280 Core #42 inserting and reading 1966080: 82,575,360 - 84,541,440 Core #44 inserting and reading 1966080: 86,507,520 - 88,473,600 Core #48 inserting and reading 1966080: 94,371,840 - 96,337,920 Core #0 inserting and reading 1966080: 0 - 1,966,080 key 1966080 is lost 1 key lost Test Failed With this patch applies, test runs as expected. Tested-by: Bruce Richardson Acked-by: Bruce Richardson