From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E1D4A1B4A8 for ; Thu, 27 Sep 2018 16:49:31 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 07:49:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,311,1534834800"; d="scan'208";a="89955410" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga002.fm.intel.com with SMTP; 27 Sep 2018 07:49:04 -0700 Received: by (sSMTP sendmail emulation); Thu, 27 Sep 2018 15:49:04 +0100 Date: Thu, 27 Sep 2018 15:49:04 +0100 From: Bruce Richardson To: Agalya Babu RadhaKrishnan Cc: dev@dpdk.org, alejandro.lucero@netronome.com, allain.legacy@windriver.com, jasvinder.singh@intel.com, keith.wiles@intel.com, matan@mellanox.com, reshma.pattan@intel.com Message-ID: <20180927144903.GB2380@bricha3-MOBL.ger.corp.intel.com> References: <1538054652-20820-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> <1538054652-20820-2-git-send-email-agalyax.babu.radhakrishnan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538054652-20820-2-git-send-email-agalyax.babu.radhakrishnan@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 1/6] build: fix for FREEBSD build via meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 14:49:32 -0000 On Thu, Sep 27, 2018 at 02:24:07PM +0100, Agalya Babu RadhaKrishnan wrote: > FreeBSD compilation was failing through meson build. > RTE_EAL_VFIO is not supported in FreeBSD. > But RTE_EAL_VFIO was enabled for both linux and freebsd. > So RTE_EAL_VFIO is removed from config/rte_config.h and > based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately. > > Fixes: 6e8a721044 ("vfio: export functions even when disabled") > > Signed-off-by: Agalya Babu RadhaKrishnan > --- > config/rte_config.h | 1 - > lib/meson.build | 6 ++++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/config/rte_config.h b/config/rte_config.h > index 567051b9c..53c568929 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -34,7 +34,6 @@ > #define RTE_MAX_TAILQ 32 > #define RTE_LOG_DP_LEVEL RTE_LOG_INFO > #define RTE_BACKTRACE 1 > -#define RTE_EAL_VFIO 1 > #define RTE_MAX_VFIO_CONTAINERS 64 > > /* bsd module defines */ > diff --git a/lib/meson.build b/lib/meson.build > index 3acc67e6e..1b20027a5 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -31,6 +31,12 @@ if cc.has_argument('-Wno-format-truncation') > default_cflags += '-Wno-format-truncation' > endif > > +if host_machine.system() == 'linux' > + dpdk_conf.set('RTE_EAL_VFIO', true) > +else > + dpdk_conf.set('RTE_EAL_VFIO', false) > +endif > + I think this can be shortened in a number of ways. If we don't have vfio, I don't think you need to set it to false, so the else leg can be removed. Even shorter again could be: dpdk_conf.set('RTE_EAL_VFIO', host_machine.system() == 'linux') /Bruce