From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 220BF1B4BD for ; Fri, 28 Sep 2018 15:25:06 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 06:25:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,315,1534834800"; d="scan'208";a="236882971" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga004.jf.intel.com with SMTP; 28 Sep 2018 06:24:29 -0700 Received: by (sSMTP sendmail emulation); Fri, 28 Sep 2018 14:24:27 +0100 Date: Fri, 28 Sep 2018 14:24:27 +0100 From: Bruce Richardson To: Ilya Maximets Cc: Maxime Coquelin , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, dgilbert@redhat.com, Thomas Monjalon Message-ID: <20180928132426.GA20200@bricha3-MOBL.ger.corp.intel.com> References: <20180926072705.22641-1-maxime.coquelin@redhat.com> <20180926072705.22641-5-maxime.coquelin@redhat.com> <20180927082608eucas1p17cd1d99e54134fb2a6de3151e52048f3~YNErH8Swu2138421384eucas1p1G@eucas1p1.samsung.com> <20180928103815eucas1p1ddb4141bea8b9ef965073a4706ccdaea~YihUJIT9-2460124601eucas1p1Z@eucas1p1.samsung.com> <20180928121334.GA6880@bricha3-MOBL.ger.corp.intel.com> <20180928131524eucas1p174f4057454f99c035b2025c4a7c7dec1~YkqhekGjc3150031500eucas1p1X@eucas1p1.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180928131524eucas1p174f4057454f99c035b2025c4a7c7dec1~YkqhekGjc3150031500eucas1p1X@eucas1p1.samsung.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 13:25:07 -0000 On Fri, Sep 28, 2018 at 04:17:34PM +0300, Ilya Maximets wrote: > On 28.09.2018 15:13, Bruce Richardson wrote: > > On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote: > >> On 27.09.2018 11:28, Ilya Maximets wrote: > >>> On 26.09.2018 10:26, Maxime Coquelin wrote: > >>>> This patch opens a userfaultfd and sends it back to Qemu's > >>>> VHOST_USER_POSTCOPY_ADVISE request. > >>>> > >>>> Signed-off-by: Dr. David Alan Gilbert > >>>> Signed-off-by: Maxime Coquelin > >>>> --- > >>>> lib/librte_vhost/vhost.h | 2 ++ > >>>> lib/librte_vhost/vhost_user.c | 37 +++++++++++++++++++++++++++++++++++ > >>>> lib/librte_vhost/vhost_user.h | 3 ++- > >>>> 3 files changed, 41 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > >>>> index 25ffd7614..21722d8a8 100644 > >>>> --- a/lib/librte_vhost/vhost.h > >>>> +++ b/lib/librte_vhost/vhost.h > >>>> @@ -363,6 +363,8 @@ struct virtio_net { > >>>> int slave_req_fd; > >>>> rte_spinlock_t slave_req_lock; > >>>> > >>>> + int postcopy_ufd; > >>>> + > >>>> /* > >>>> * Device id to identify a specific backend device. > >>>> * It's set to -1 for the default software implementation. > >>>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > >>>> index a9b429598..bdfe2cac0 100644 > >>>> --- a/lib/librte_vhost/vhost_user.c > >>>> +++ b/lib/librte_vhost/vhost_user.c > >>>> @@ -24,9 +24,13 @@ > >>>> #include > >>>> #include > >>>> #include > >>>> +#include > >>>> +#include > >>> > >>> Maybe we need compile time check for this header existence? > >>> Otherwise, this will bump minimal kernel version for default linux build > >>> to something like 4.3. > >> > >> We'll need a config option here (disabled by default) and guard all > >> the postcopy related code. > >> Meson build will be able to detect the header file and enable > >> the config if possible. Like this: > >> > >> lib/librte_vhost/meson.build: > >> if cc.has_header('linux/userfaultfd.h') > >> dpdk_conf.set10('RTE_LIBRTE_VHOST_POSTCOPY', true) > > > > Are you sure you want 'set10' rather than 'set'. Set is probably easier > > because it ensures no define on false, while set10 has a define of 0. This > > has caught me out before. > > > > FYI, you can also avoid the if by putting the condition into the define: > > > > dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('...')) > > Sure, this variant looks better. Thanks for suggestions. > I just copied my version from the similar code for 'RTE_HAS_LIBNUMA'. > Yes, looking at that code, it could do with a clean-up to shorten it too. [It's true that nothing embarasses a programmer more than their own code 6 months layer :-)] /Bruce