From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AA5061B1F4 for ; Fri, 28 Sep 2018 12:49:55 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 03:49:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,314,1534834800"; d="scan'208";a="92883736" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207]) by fmsmga004.fm.intel.com with ESMTP; 28 Sep 2018 03:49:36 -0700 Date: Sat, 29 Sep 2018 01:37:33 +0800 From: Ye Xiaolong To: Maxime Coquelin Cc: dev@dpdk.org, Tiwei Bie , Zhihong Wang , xiao.w.wang@intel.com, Rami Rosen , Wang Haiyue Message-ID: <20180928173733.GA45525@intel.com> References: <20180926090638.4705-1-xiaolong.ye@intel.com> <20180928112344.42791-1-xiaolong.ye@intel.com> <20180928112344.42791-3-xiaolong.ye@intel.com> <20180928143353.GA44187@intel.com> <20180928151733.GA44818@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 10:49:56 -0000 On 09/28, Maxime Coquelin wrote: > > >On 09/28/2018 05:17 PM, Ye Xiaolong wrote: >> On 09/28, Maxime Coquelin wrote: >> > >> > >> > On 09/28/2018 04:33 PM, Ye Xiaolong wrote: >> > > On 09/28, Maxime Coquelin wrote: >> > > > > + ret = rte_eal_init(argc, argv); >> > > > > + if (ret < 0) >> > > > > + rte_exit(EXIT_FAILURE, "eal init failed\n"); >> > > > > + argc -= ret; >> > > > > + argv += ret; >> > > > > + >> > > > > + data_init(); >> > > > >> > > > You need to check return from data_init(). >> > > > If this is fine for you, I can change to below code when applying: >> > > > >> > > > ret = data_init(); >> > > > if (ret < 0) >> > > > rte_exit(EXIT_FAILURE, "data init failed\n"); >> > > > >> > > > >> > > >> > > I'm fine with this change. >> > >> > Or even better, get rid of data_init and >> > call rte_vdpa_get_device_num(); in main directly. >> >> Sounds better, as we've removed unnecessary static variable initialization in >> data_init, it does nothing but call rte_vdpa_get_device_num, we can remove this >> wrap. Would you do this change when applying or you perfer I send a new >> revision? > >Please send a new revision, and in the commit message, >fix first letter of my family name with an upper case, >and move my R-b below your sign-off. Got it. Thanks, Xiaolong > >Thanks! >Maxime > >> Thanks, >> Xiaolong >> >> >> > >> > > Thanks, >> > > Xiaolong >> > >