From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 20B78160 for ; Mon, 1 Oct 2018 11:31:14 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 02:31:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,327,1534834800"; d="scan'208";a="91053780" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga002.fm.intel.com with SMTP; 01 Oct 2018 02:31:11 -0700 Received: by (sSMTP sendmail emulation); Mon, 01 Oct 2018 10:31:10 +0100 Date: Mon, 1 Oct 2018 10:31:10 +0100 From: Bruce Richardson To: Hari Kumar Vemula Cc: dev@dpdk.org, reshma.pattan@intel.com, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com Message-ID: <20181001093110.GC25944@bricha3-MOBL.ger.corp.intel.com> References: <1538222461-25597-1-git-send-email-hari.kumarx.vemula@intel.com> <1538222461-25597-2-git-send-email-hari.kumarx.vemula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538222461-25597-2-git-send-email-hari.kumarx.vemula@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 09:31:15 -0000 On Sat, Sep 29, 2018 at 01:00:58PM +0100, Hari Kumar Vemula wrote: > Added new meson.build files for aesni_gcm > Exported dependency library path through meson_options.txt file > > Signed-off-by: Hari Kumar Vemula > --- > drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++ > drivers/crypto/meson.build | 2 +- > meson_options.txt | 2 ++ > 3 files changed, 20 insertions(+), 1 deletion(-) > create mode 100644 drivers/crypto/aesni_gcm/meson.build > > diff --git a/drivers/crypto/aesni_gcm/meson.build b/drivers/crypto/aesni_gcm/meson.build > new file mode 100644 > index 000000000..a84c792c5 > --- /dev/null > +++ b/drivers/crypto/aesni_gcm/meson.build > @@ -0,0 +1,17 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2018 Intel Corporation > + > +path = get_option('lib_IPSec_MB') > +lib_dir = path + '/lib' > + lib_dir doesn't seem to be used after being assigned, whcih means that having the build option is unnecessary. > +lib = cc.find_library('IPSec_MB', required: false) > +if not lib.found() > + build = false > +else > + ext_deps += lib > +endif > + > +sources = files('aesni_gcm_pmd.c', 'aesni_gcm_pmd_ops.c') > + > +deps += ['bus_vdev'] > + You don't seem to require any header file paths from the IPSec_MD library, so even if you need the path for the lib, you can used LD_LIBRARY_PATH environment variable to point to it rather than needing a build-time option. I'd like to avoid adding unnecessary options, if possible. > diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build > index 6ed853b7a..7e14cbba0 100644 > --- a/drivers/crypto/meson.build > +++ b/drivers/crypto/meson.build > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam', > +drivers = ['aesni_gcm', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam', > 'null', 'openssl', 'qat', 'scheduler', 'virtio'] > > std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps > diff --git a/meson_options.txt b/meson_options.txt > index d38ba56e2..8c75826c1 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -24,3 +24,5 @@ option('use_hpet', type: 'boolean', value: false, > description: 'use HPET timer in EAL') > option('tests', type: 'boolean', value: true, > description: 'build unit tests') > +option('lib_IPSec_MB', type: 'string', value: '', > + description: 'path to the IPSec_MB library installation directory') > -- > 2.13.6 >